diff options
| author | bartfab <bartfab@chromium.org> | 2015-01-19 04:50:25 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-01-19 12:51:25 +0000 |
| commit | 4fe2125920ff2503f299d4a12e5d5b291139175b (patch) | |
| tree | 18ffa2d80fa6c4d0ca748262a39cdc3cf443d8d4 /content/test | |
| parent | babd5a0011a43ad14537e5fa2b4ae0d5941c3e0a (diff) | |
| download | chromium_src-4fe2125920ff2503f299d4a12e5d5b291139175b.zip chromium_src-4fe2125920ff2503f299d4a12e5d5b291139175b.tar.gz chromium_src-4fe2125920ff2503f299d4a12e5d5b291139175b.tar.bz2 | |
Revert of On Android, links inside headings should be announced as headings by TalkBack (patchset #4 id:60001 of https://codereview.chromium.org/845663002/)
Reason for revert:
This caused content_browsertests to fail on the Android bots, e.g.:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/17857
C 1232.064s Main [FAIL] DumpAccessibilityTreeTest.AccessibilityLinkInsideHeading:
C 1232.064s Main [WARNING:dns_config_service_posix.cc(293)] Failed to read DnsConfig.
C 1232.065s Main [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
C 1232.065s Main [WARNING:proxy_service.cc(899)] PAC support disabled because there is no system implementation
C 1232.065s Main Testing: /storage/emulated/0/content/test/data/accessibility/html/link-inside-heading.html
C 1232.065s Main ../../content/browser/accessibility/dump_accessibility_browsertest_base.cc:202: Failure
C 1232.065s Main Value of: is_different
C 1232.065s Main Actual: true
C 1232.065s Main Expected: false
C 1232.065s Main * Line Expected
C 1232.065s Main - ---- --------
C 1232.065s Main 1 android.webkit.WebView focusable focused scrollable
C 1232.065s Main 2 android.view.View heading
C 1232.065s Main * 3 android.view.View clickable focusable heading name='Link In Heading'
C 1232.065s Main 4 <-- End-of-file -->
C 1232.065s Main
C 1232.065s Main Actual
C 1232.065s Main ------
C 1232.065s Main android.webkit.WebView focusable focused scrollable
C 1232.065s Main android.view.View heading
C 1232.066s Main android.view.View clickable focusable heading link name='Link In Heading'
C 1232.066s Main <-- End-of-file -->
Original issue's description:
> On Android, links inside headings should be announced as headings by TalkBack
>
> BUG=446216
>
> Committed: https://crrev.com/68e8e33eff3a16754b9a99681d0586041436bb62
> Cr-Commit-Position: refs/heads/master@{#312086}
TBR=dmazzoni@chromium.org,aboxhall@chromium.org,ramya.v@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=446216
Review URL: https://codereview.chromium.org/862503002
Cr-Commit-Position: refs/heads/master@{#312102}
Diffstat (limited to 'content/test')
4 files changed, 0 insertions, 17 deletions
diff --git a/content/test/data/accessibility/html/link-inside-heading-expected-android.txt b/content/test/data/accessibility/html/link-inside-heading-expected-android.txt deleted file mode 100644 index b0c653c..0000000 --- a/content/test/data/accessibility/html/link-inside-heading-expected-android.txt +++ /dev/null @@ -1,3 +0,0 @@ -android.webkit.WebView focusable focused scrollable - android.view.View heading - android.view.View clickable focusable heading name='Link In Heading' diff --git a/content/test/data/accessibility/html/link-inside-heading-expected-mac.txt b/content/test/data/accessibility/html/link-inside-heading-expected-mac.txt deleted file mode 100644 index fa57293..0000000 --- a/content/test/data/accessibility/html/link-inside-heading-expected-mac.txt +++ /dev/null @@ -1,4 +0,0 @@ -AXWebArea - AXHeading AXValue='1' - AXLink AXTitle='Link In Heading' - AXStaticText AXValue='Link In Heading' diff --git a/content/test/data/accessibility/html/link-inside-heading-expected-win.txt b/content/test/data/accessibility/html/link-inside-heading-expected-win.txt deleted file mode 100644 index fb43846..0000000 --- a/content/test/data/accessibility/html/link-inside-heading-expected-win.txt +++ /dev/null @@ -1,4 +0,0 @@ -ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE - IA2_ROLE_HEADING - ROLE_SYSTEM_LINK name='Link In Heading' FOCUSABLE - ROLE_SYSTEM_STATICTEXT name='Link In Heading' diff --git a/content/test/data/accessibility/html/link-inside-heading.html b/content/test/data/accessibility/html/link-inside-heading.html deleted file mode 100644 index 28ef901..0000000 --- a/content/test/data/accessibility/html/link-inside-heading.html +++ /dev/null @@ -1,6 +0,0 @@ -<!DOCTYPE html> -<html> - <body> - <h1><a href="#">Link In Heading</a></h1> - </body> -</html>
\ No newline at end of file |