Fixing Coverity bugs (DEAD_CODE and PASS_BY_VALUE)

CIDs 16230, 16439, 16610, 16635

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/7215029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90134 0039d316-1c4b-4281-b951-d872f2087c98

7 files changed, 6 insertions, 9 deletions

diff --git a/content/browser/gpu/gpu_data_manager.cc b/content/browser/gpu/gpu_data_manager.cc
index fdcdd63..506f10e 100644
--- a/content/browser/gpu/gpu_data_manager.cc
+++ b/content/browser/gpu/gpu_data_manager.cc
@@ -226,9 +226,6 @@ void GpuDataManager::UpdateGpuFeatureFlags() {
   }
 
   GpuBlacklist* gpu_blacklist = GetGpuBlacklist();
-  if (gpu_blacklist == NULL)
-    return;
-
   // We don't set a lock around modifying gpu_feature_flags_ since it's just an
   // int.
   if (!gpu_blacklist) {
diff --git a/content/browser/renderer_host/clipboard_message_filter.cc b/content/browser/renderer_host/clipboard_message_filter.cc
index 7e9e712..ab78b63 100644
--- a/content/browser/renderer_host/clipboard_message_filter.cc
+++ b/content/browser/renderer_host/clipboard_message_filter.cc
@@ -162,7 +162,7 @@ void ClipboardMessageFilter::OnReadImage(
 }
 
 void ClipboardMessageFilter::OnReadImageReply(
-    SkBitmap bitmap, IPC::Message* reply_msg) {
+    const SkBitmap& bitmap, IPC::Message* reply_msg) {
   base::SharedMemoryHandle image_handle = base::SharedMemory::NULLHandle();
   uint32 image_size = 0;
   std::string reply_data;
diff --git a/content/browser/renderer_host/clipboard_message_filter.h b/content/browser/renderer_host/clipboard_message_filter.h
index 854c25e..7ad7d0e 100644
--- a/content/browser/renderer_host/clipboard_message_filter.h
+++ b/content/browser/renderer_host/clipboard_message_filter.h
@@ -39,7 +39,7 @@ class ClipboardMessageFilter : public BrowserMessageFilter {
   void OnReadAsciiText(ui::Clipboard::Buffer buffer, std::string* result);
   void OnReadHTML(ui::Clipboard::Buffer buffer, string16* markup, GURL* url);
   void OnReadImage(ui::Clipboard::Buffer buffer, IPC::Message* reply_msg);
-  void OnReadImageReply(SkBitmap bitmap, IPC::Message* reply_msg);
+  void OnReadImageReply(const SkBitmap& bitmap, IPC::Message* reply_msg);
 #if defined(OS_MACOSX)
   void OnFindPboardWriteString(const string16& text);
 #endif
diff --git a/content/browser/renderer_host/p2p/socket_dispatcher_host.cc b/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
index b2cd77a..57169ef 100644
--- a/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
+++ b/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
@@ -97,7 +97,7 @@ void P2PSocketDispatcherHost::OnCreateSocket(
 
 void P2PSocketDispatcherHost::OnAcceptIncomingTcpConnection(
     const IPC::Message& msg, int listen_socket_id,
-    net::IPEndPoint remote_address, int connected_socket_id) {
+    const net::IPEndPoint& remote_address, int connected_socket_id) {
   P2PSocketHost* socket = LookupSocket(msg.routing_id(), listen_socket_id);
   if (!socket) {
     LOG(ERROR) << "Received P2PHostMsg_AcceptIncomingTcpConnection "
diff --git a/content/browser/renderer_host/p2p/socket_dispatcher_host.h b/content/browser/renderer_host/p2p/socket_dispatcher_host.h
index dffc111..562c463 100644
--- a/content/browser/renderer_host/p2p/socket_dispatcher_host.h
+++ b/content/browser/renderer_host/p2p/socket_dispatcher_host.h
@@ -39,7 +39,7 @@ class P2PSocketDispatcherHost : public BrowserMessageFilter {
                       const net::IPEndPoint& remote_address);
   void OnAcceptIncomingTcpConnection(const IPC::Message& msg,
                                      int listen_socket_id,
-                                     net::IPEndPoint remote_address,
+                                     const net::IPEndPoint& remote_address,
                                      int connected_socket_id);
   void OnSend(const IPC::Message& msg, int socket_id,
               const net::IPEndPoint& socket_address,
diff --git a/content/common/gpu/transport_texture.cc b/content/common/gpu/transport_texture.cc
index 656c619..c4ff8cd 100644
--- a/content/common/gpu/transport_texture.cc
+++ b/content/common/gpu/transport_texture.cc
@@ -83,7 +83,7 @@ void TransportTexture::OnDestroy() {
   channel_->DestroyTransportTexture(route_id_);
 }
 
-void TransportTexture::OnTexturesCreated(std::vector<int> textures) {
+void TransportTexture::OnTexturesCreated(const std::vector<int>& textures) {
   bool ret = decoder_->MakeCurrent();
   if (!ret) {
     LOG(ERROR) << "Failed to switch context";
diff --git a/content/common/gpu/transport_texture.h b/content/common/gpu/transport_texture.h
index c3291d2..3e01687 100644
--- a/content/common/gpu/transport_texture.h
+++ b/content/common/gpu/transport_texture.h
@@ -71,7 +71,7 @@ class TransportTexture : public IPC::Channel::Listener {
   ///////////////////////////////////////////////////////////////////////////
   // IPC Message Handlers
   void OnDestroy();
-  void OnTexturesCreated(std::vector<int> textures);
+  void OnTexturesCreated(const std::vector<int>& textures);
 
   GpuChannel* channel_;
   IPC::Message::Sender* sender_;