diff options
| author | kbr@chromium.org <kbr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-09 00:09:06 +0000 |
|---|---|---|
| committer | kbr@chromium.org <kbr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-09 00:09:06 +0000 |
| commit | 25301e91c5502e357fe42abbaf68da3f3d9cdaac (patch) | |
| tree | a151c8a2e8ea33dc299ac9c1ff9d0ae7dbc54a53 /content | |
| parent | 73fb1fc539a47835811f806342f9bf72f77a15df (diff) | |
| download | chromium_src-25301e91c5502e357fe42abbaf68da3f3d9cdaac.zip chromium_src-25301e91c5502e357fe42abbaf68da3f3d9cdaac.tar.gz chromium_src-25301e91c5502e357fe42abbaf68da3f3d9cdaac.tar.bz2 | |
Work around assertion failure when child process crashes by updating
inherited copy of handle from ChildProcessInfo when child dies.
BUG=88769
TEST=none (manually ran steps in bug report)
Review URL: http://codereview.chromium.org/7327022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91924 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
| -rw-r--r-- | content/browser/browser_child_process_host.cc | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/content/browser/browser_child_process_host.cc b/content/browser/browser_child_process_host.cc index 4a65aa0..d1a874e 100644 --- a/content/browser/browser_child_process_host.cc +++ b/content/browser/browser_child_process_host.cc @@ -124,6 +124,11 @@ base::TerminationStatus BrowserChildProcessHost::GetChildTerminationStatus( } void BrowserChildProcessHost::OnChildDied() { + // TODO(kbr): the duplication of the child process's handle between + // child_process_ and our inheritance from ChildProcessInfo is + // problematic and needs to be cleaned up. Ideally I think this + // class would not derive from ChildProcessInfo. See bug 88769. + set_handle(child_process_->GetHandle()); if (handle() != base::kNullProcessHandle) { int exit_code; base::TerminationStatus status = GetChildTerminationStatus(&exit_code); |