summaryrefslogtreecommitdiffstats
path: root/content
diff options
context:
space:
mode:
authorrvargas@google.com <rvargas@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-12 17:33:21 +0000
committerrvargas@google.com <rvargas@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-12 17:33:21 +0000
commite51ddf25f1d720b18fc862ce683897c12c223525 (patch)
treea3584e27940984934404648d694ceaca8fd7f7ea /content
parent76c0f69b2a933abcc3edb5b952834ed952d2463e (diff)
downloadchromium_src-e51ddf25f1d720b18fc862ce683897c12c223525.zip
chromium_src-e51ddf25f1d720b18fc862ce683897c12c223525.tar.gz
chromium_src-e51ddf25f1d720b18fc862ce683897c12c223525.tar.bz2
Content: Log an error when we are unable to launch child
processes. BUG=82226 TEST=none Review URL: http://codereview.chromium.org/8228027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105111 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
-rw-r--r--content/browser/child_process_launcher.cc3
-rw-r--r--content/common/sandbox_policy.cc4
2 files changed, 6 insertions, 1 deletions
diff --git a/content/browser/child_process_launcher.cc b/content/browser/child_process_launcher.cc
index f73cbef..8e14048 100644
--- a/content/browser/child_process_launcher.cc
+++ b/content/browser/child_process_launcher.cc
@@ -219,6 +219,9 @@ class ChildProcessLauncher::Context
base::ProcessHandle handle) {
starting_ = false;
process_.set_handle(handle);
+ if (!handle)
+ LOG(ERROR) << "Failed to launch child process";
+
#if defined(OS_POSIX) && !defined(OS_MACOSX)
zygote_ = zygote;
#endif
diff --git a/content/common/sandbox_policy.cc b/content/common/sandbox_policy.cc
index 0e29af7..f9a442c 100644
--- a/content/common/sandbox_policy.cc
+++ b/content/common/sandbox_policy.cc
@@ -531,8 +531,10 @@ base::ProcessHandle StartProcessWithAccess(CommandLine* cmd_line,
TRACE_EVENT_END_ETW("StartProcessWithAccess::LAUNCHPROCESS", 0, 0);
- if (sandbox::SBOX_ALL_OK != result)
+ if (sandbox::SBOX_ALL_OK != result) {
+ LOG(ERROR) << "Failed to launch process. Error: " << result;
return 0;
+ }
// For Native Client sel_ldr processes on 32-bit Windows, reserve 1 GB of
// address space to prevent later failure due to address space fragmentation