diff options
| author | asanka@chromium.org <asanka@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-16 03:06:33 +0000 |
|---|---|---|
| committer | asanka@chromium.org <asanka@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-16 03:06:33 +0000 |
| commit | a85bbcdc9ec30bd14646893a4d5434e6173f010c (patch) | |
| tree | 746b648655549f272f4bf3b6aec213fb7d58a3a3 /content | |
| parent | 8b0f2cc2f919bcc0f5f445a3de0a2f3eb868e0e4 (diff) | |
| download | chromium_src-a85bbcdc9ec30bd14646893a4d5434e6173f010c.zip chromium_src-a85bbcdc9ec30bd14646893a4d5434e6173f010c.tar.gz chromium_src-a85bbcdc9ec30bd14646893a4d5434e6173f010c.tar.bz2 | |
Add new danger type for uncommon or unknown downloads.
BUG=102540
TEST=Downloading a binary that is marked by the safe browsing service as uncommon should show the uncommon download warning.
Review URL: https://chromiumcodereview.appspot.com/9621007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127093 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
| -rw-r--r-- | content/browser/download/download_net_log_parameters.cc | 3 | ||||
| -rw-r--r-- | content/browser/download/download_state_info.cc | 3 | ||||
| -rw-r--r-- | content/public/browser/download_danger_type.h | 4 |
3 files changed, 8 insertions, 2 deletions
diff --git a/content/browser/download/download_net_log_parameters.cc b/content/browser/download/download_net_log_parameters.cc index 6e5399e..8211cfc 100644 --- a/content/browser/download/download_net_log_parameters.cc +++ b/content/browser/download/download_net_log_parameters.cc @@ -30,7 +30,8 @@ static const char* download_danger_names[] = { "DANGEROUS_FILE", "DANGEROUS_URL", "DANGEROUS_CONTENT", - "MAYBE_DANGEROUS_CONTENT" + "MAYBE_DANGEROUS_CONTENT", + "UNCOMMON_CONTENT" }; COMPILE_ASSERT(ARRAYSIZE_UNSAFE(download_type_names) == SRC_SAVE_PAGE_AS + 1, diff --git a/content/browser/download/download_state_info.cc b/content/browser/download/download_state_info.cc index 0031eb3..b927fb0 100644 --- a/content/browser/download/download_state_info.cc +++ b/content/browser/download/download_state_info.cc @@ -32,7 +32,8 @@ bool DownloadStateInfo::IsDangerous() const { #ifdef OS_WIN return (danger == content::DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE || danger == content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL || - danger == content::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT); + danger == content::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT || + danger == content::DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT); #else return (danger == content::DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE || danger == content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL); diff --git a/content/public/browser/download_danger_type.h b/content/public/browser/download_danger_type.h index 2c8ba88..a7f9942 100644 --- a/content/public/browser/download_danger_type.h +++ b/content/public/browser/download_danger_type.h @@ -29,6 +29,10 @@ enum DownloadDangerType { // SafeBrowsing has not finished checking the content). DOWNLOAD_DANGER_TYPE_MAYBE_DANGEROUS_CONTENT, + // SafeBrowsing download service checked the contents of the download, but + // didn't have enough data to determine whether it was malicious. + DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT, + // Memory space for histograms is determined by the max. // ALWAYS ADD NEW VALUES BEFORE THIS ONE. DOWNLOAD_DANGER_TYPE_MAX |