diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-09 17:21:39 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-09 17:21:39 +0000 |
| commit | 3c1cd7b1a53b887ff4ac4c658fabcd8e1399ca73 (patch) | |
| tree | 1f83faa64982418daebc9f355cfe0a96224177c2 /content | |
| parent | 137bd27e9e0ba03c3754b10fee1293b39016e59d (diff) | |
| download | chromium_src-3c1cd7b1a53b887ff4ac4c658fabcd8e1399ca73.zip chromium_src-3c1cd7b1a53b887ff4ac4c658fabcd8e1399ca73.tar.gz chromium_src-3c1cd7b1a53b887ff4ac4c658fabcd8e1399ca73.tar.bz2 | |
Fix test issues seen when using WebContentsViewWin by default on Chrome.
-fix unittest crashes because in tests the parent window of the constrained window is a TCVWin which is not a Views::Widget. As a result FocusManager is sometimes NULL.
-ensure that TabContentsViewWin destroys the HWND in its destructor. This is what TabContentsViewViews does indirectly through NativeWidgetWin.
I'll enable TabContentsViewWin by default in a separate change.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9635020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125851 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
| -rw-r--r-- | content/browser/tab_contents/tab_contents_view_win.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/content/browser/tab_contents/tab_contents_view_win.cc b/content/browser/tab_contents/tab_contents_view_win.cc index 7304d7f..8401e3a 100644 --- a/content/browser/tab_contents/tab_contents_view_win.cc +++ b/content/browser/tab_contents/tab_contents_view_win.cc @@ -65,6 +65,8 @@ TabContentsViewWin::TabContentsViewWin(WebContents* web_contents, } TabContentsViewWin::~TabContentsViewWin() { + if (IsWindow(hwnd())) + DestroyWindow(hwnd()); } void TabContentsViewWin::CreateView(const gfx::Size& initial_size) { |