diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-16 17:48:34 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-16 17:48:34 +0000 |
| commit | 3d143e9b4beec02c615bd47a6a267a0ba24992cd (patch) | |
| tree | 8b2ea9b7a5471d2fe70b3839602af79c70b8a99d /content | |
| parent | d143750beccc3ac206857afb2950e25b7175654d (diff) | |
| download | chromium_src-3d143e9b4beec02c615bd47a6a267a0ba24992cd.zip chromium_src-3d143e9b4beec02c615bd47a6a267a0ba24992cd.tar.gz chromium_src-3d143e9b4beec02c615bd47a6a267a0ba24992cd.tar.bz2 | |
Remove the include dependency of the chrome_notification_types.h header from content.
The dependency was in the ResourceDispatcherHostBrowserTest code which subscribed to
the chrome::NOTIFICATION_BROWSER_WINDOW_READY event fired by Chrome.
To remove this dependency these tests now subscribe to the notification content::NOTIFICATION_TAB_ADDED
which is fired after the above notification.
Fixes bug http://crbug.com/88871
BUG=88871
Review URL: http://codereview.chromium.org/7648045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96975 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
| -rw-r--r-- | content/browser/DEPS | 3 | ||||
| -rw-r--r-- | content/browser/renderer_host/resource_dispatcher_host_browsertest.cc | 4 |
2 files changed, 2 insertions, 5 deletions
diff --git a/content/browser/DEPS b/content/browser/DEPS index 78c6904..ef18b72 100644 --- a/content/browser/DEPS +++ b/content/browser/DEPS @@ -22,8 +22,5 @@ include_rules = [ # ONLY USED BY TESTS "+chrome/browser/ui/browser.h", - # http://crbug.com/88871 - "+chrome/common/chrome_notification_types.h", - # DO NOT ADD ANY MORE TO THIS LIST!!! SEE ABOVE COMMENT ] diff --git a/content/browser/renderer_host/resource_dispatcher_host_browsertest.cc b/content/browser/renderer_host/resource_dispatcher_host_browsertest.cc index e0a59c7..a3cb48c 100644 --- a/content/browser/renderer_host/resource_dispatcher_host_browsertest.cc +++ b/content/browser/renderer_host/resource_dispatcher_host_browsertest.cc @@ -5,10 +5,10 @@ #include "base/string_util.h" #include "base/utf_string_conversions.h" #include "chrome/browser/ui/browser.h" -#include "chrome/common/chrome_notification_types.h" #include "chrome/test/base/in_process_browser_test.h" #include "chrome/test/base/ui_test_utils.h" #include "content/browser/tab_contents/tab_contents.h" +#include "content/common/content_notification_types.h" #include "net/test/test_server.h" class ResourceDispatcherHostBrowserTest : public InProcessBrowserTest { @@ -30,7 +30,7 @@ bool ResourceDispatcherHostBrowserTest::GetPopupTitle(const GURL& url, ui_test_utils::NavigateToURL(browser(), url); ui_test_utils::WindowedNotificationObserver observer( - chrome::NOTIFICATION_BROWSER_WINDOW_READY, + content::NOTIFICATION_TAB_ADDED, NotificationService::AllSources()); // Create dynamic popup. |