diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-12 01:29:27 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-12 01:29:27 +0000 |
| commit | 4eee045cef873bb481b5addc0abc8d0deac89604 (patch) | |
| tree | 41be89706cc38780932a39e13e661bd6608274f2 /content | |
| parent | 75de721b7a3aa1b97189dac543487cf06080ec42 (diff) | |
| download | chromium_src-4eee045cef873bb481b5addc0abc8d0deac89604.zip chromium_src-4eee045cef873bb481b5addc0abc8d0deac89604.tar.gz chromium_src-4eee045cef873bb481b5addc0abc8d0deac89604.tar.bz2 | |
Add the StackTrace to the URLFetcher crash dumps.
This will help me in narrowing down which URLFetcher is leaking the URLRequest in these crashes.
BUG= 90971,127860
TBR=eroman
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10383145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136736 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
| -rw-r--r-- | content/common/net/url_fetcher_core.cc | 1 | ||||
| -rw-r--r-- | content/common/net/url_fetcher_core.h | 4 |
2 files changed, 5 insertions, 0 deletions
diff --git a/content/common/net/url_fetcher_core.cc b/content/common/net/url_fetcher_core.cc index a96c5da..07b060f 100644 --- a/content/common/net/url_fetcher_core.cc +++ b/content/common/net/url_fetcher_core.cc @@ -724,6 +724,7 @@ void URLFetcherCore::StartURLRequest() { g_registry.Get().AddURLFetcherCore(this); current_response_bytes_ = 0; request_.reset(new net::URLRequest(original_url_, this)); + request_->set_stack_trace(stack_trace_); int flags = request_->load_flags() | load_flags_; if (!g_interception_enabled) flags = flags | net::LOAD_DISABLE_INTERCEPT; diff --git a/content/common/net/url_fetcher_core.h b/content/common/net/url_fetcher_core.h index 387c75c..6578569 100644 --- a/content/common/net/url_fetcher_core.h +++ b/content/common/net/url_fetcher_core.h @@ -12,6 +12,7 @@ #include "base/basictypes.h" #include "base/callback_forward.h" #include "base/compiler_specific.h" +#include "base/debug/stack_trace.h" #include "base/file_path.h" #include "base/lazy_instance.h" #include "base/memory/ref_counted.h" @@ -394,6 +395,9 @@ class URLFetcherCore // Total expected bytes to receive (-1 if it cannot be determined). int64 total_response_bytes_; + // TODO(willchan): Get rid of this after debugging crbug.com/90971. + base::debug::StackTrace stack_trace_; + static base::LazyInstance<Registry> g_registry; DISALLOW_COPY_AND_ASSIGN(URLFetcherCore); |