diff options
| author | cmp@chromium.org <cmp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-04 20:42:53 +0000 |
|---|---|---|
| committer | cmp@chromium.org <cmp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-04 20:42:53 +0000 |
| commit | 8fda0ab08a219c0d96e3d51d26479d10f386ee30 (patch) | |
| tree | fc16acfbfebd0795629f7e4c87e0500258566cfc /content | |
| parent | 38b8971cd5d5a9481d571d7bfca44a06566111d5 (diff) | |
| download | chromium_src-8fda0ab08a219c0d96e3d51d26479d10f386ee30.zip chromium_src-8fda0ab08a219c0d96e3d51d26479d10f386ee30.tar.gz chromium_src-8fda0ab08a219c0d96e3d51d26479d10f386ee30.tar.bz2 | |
Revert 80318 - Detach the PromoResourceService and WebResourceService from the Profile; have them store web resource data in local state instead.
We don't need multiple services for different Profiles; instead, there is a single service that captures data in local_state. The only preference stored in the Profile about the promo will be a bool indicating whether it's been closed or not, which will now be set outside the service.
Reviewers:
arv for general changes to PromoResourceService, & unittest.
erg for pulling the service out of the Profile and serving it up as a Singleton.
zmo for the changes I made to gpu_data_manager.
jstritar FYI, for changes to the PromoResourceService.
BUG=77155
TEST=promo resource service unittests.
Review URL: http://codereview.chromium.org/6736028
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/6677140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80369 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
| -rw-r--r-- | content/common/notification_type.h | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/content/common/notification_type.h b/content/common/notification_type.h index 9593573..74f2b38 100644 --- a/content/common/notification_type.h +++ b/content/common/notification_type.h @@ -786,15 +786,11 @@ class NotificationType { // should be the UI thread. DEFAULT_REQUEST_CONTEXT_AVAILABLE, - // The state of a promo resource has been changed. A resource may have been + // The state of a web resource has been changed. A resource may have been // added, removed, or altered. Source is WebResourceService, and the // details are NoDetails. PROMO_RESOURCE_STATE_CHANGED, - // The user has elected not to display the promo on the New Tab Page. - // Source is WebResourceService, and the details are NoDetails. - PROMO_CLOSED, - // Autocomplete ------------------------------------------------------------ // Sent by the autocomplete controller when done. The source is the |