diff options
author | amogh.bihani@samsung.com <amogh.bihani@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-15 03:29:51 +0000 |
---|---|---|
committer | amogh.bihani@samsung.com <amogh.bihani@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-15 03:29:51 +0000 |
commit | abc677793ff8bff776a9454f29b934138dbe5a99 (patch) | |
tree | 2a4c7f05726b02e64c97350e314067fdd780eb64 /content | |
parent | 7fb5a799f5425facc04221d586cd06c45a62403c (diff) | |
download | chromium_src-abc677793ff8bff776a9454f29b934138dbe5a99.zip chromium_src-abc677793ff8bff776a9454f29b934138dbe5a99.tar.gz chromium_src-abc677793ff8bff776a9454f29b934138dbe5a99.tar.bz2 |
Using PROFILE_ANY for vp8 and vp9
VP8 and VP9 do not take profile into account. Using PROFILE_MAIN is confusing.
This patch uses PROFILE_ANY for these codecs.
TBR=noelallen@chromium.org
BUG=361676
Review URL: https://codereview.chromium.org/418193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289765 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
9 files changed, 16 insertions, 18 deletions
diff --git a/content/common/gpu/media/android_video_decode_accelerator.cc b/content/common/gpu/media/android_video_decode_accelerator.cc index a9392de..b1de5b1 100644 --- a/content/common/gpu/media/android_video_decode_accelerator.cc +++ b/content/common/gpu/media/android_video_decode_accelerator.cc @@ -89,7 +89,7 @@ bool AndroidVideoDecodeAccelerator::Initialize(media::VideoCodecProfile profile, client_ = client; - if (profile == media::VP8PROFILE_MAIN) { + if (profile == media::VP8PROFILE_ANY) { codec_ = media::kCodecVP8; } else { // TODO(dwkang): enable H264 once b/8125974 is fixed. diff --git a/content/common/gpu/media/android_video_encode_accelerator.cc b/content/common/gpu/media/android_video_encode_accelerator.cc index a6406c1..f124b14 100644 --- a/content/common/gpu/media/android_video_encode_accelerator.cc +++ b/content/common/gpu/media/android_video_encode_accelerator.cc @@ -100,7 +100,7 @@ AndroidVideoEncodeAccelerator::GetSupportedProfiles() { continue; } SupportedProfile profile; - profile.profile = media::VP8PROFILE_MAIN; + profile.profile = media::VP8PROFILE_ANY; // Wouldn't it be nice if MediaCodec exposed the maximum capabilities of the // encoder? Sure would be. Too bad it doesn't. So we hard-code some // reasonable defaults. @@ -129,7 +129,7 @@ bool AndroidVideoEncodeAccelerator::Initialize( if (!(media::MediaCodecBridge::SupportsSetParameters() && format == VideoFrame::I420 && - output_profile == media::VP8PROFILE_MAIN)) { + output_profile == media::VP8PROFILE_ANY)) { DLOG(ERROR) << "Unexpected combo: " << format << ", " << output_profile; return false; } diff --git a/content/common/gpu/media/v4l2_video_decode_accelerator.cc b/content/common/gpu/media/v4l2_video_decode_accelerator.cc index 1b47516..315b2f5 100644 --- a/content/common/gpu/media/v4l2_video_decode_accelerator.cc +++ b/content/common/gpu/media/v4l2_video_decode_accelerator.cc @@ -224,8 +224,8 @@ bool V4L2VideoDecodeAccelerator::Initialize(media::VideoCodecProfile profile, case media::H264PROFILE_HIGH: DVLOG(2) << "Initialize(): profile H264PROFILE_HIGH"; break; - case media::VP8PROFILE_MAIN: - DVLOG(2) << "Initialize(): profile VP8PROFILE_MAIN"; + case media::VP8PROFILE_ANY: + DVLOG(2) << "Initialize(): profile VP8PROFILE_ANY"; break; default: DLOG(ERROR) << "Initialize(): unsupported profile=" << profile; diff --git a/content/common/gpu/media/v4l2_video_encode_accelerator.cc b/content/common/gpu/media/v4l2_video_encode_accelerator.cc index b3967ea..25320f4 100644 --- a/content/common/gpu/media/v4l2_video_encode_accelerator.cc +++ b/content/common/gpu/media/v4l2_video_encode_accelerator.cc @@ -288,7 +288,7 @@ V4L2VideoEncodeAccelerator::GetSupportedProfiles() { const base::CommandLine* cmd_line = base::CommandLine::ForCurrentProcess(); if (cmd_line->HasSwitch(switches::kEnableWebRtcHWVp8Encoding)) { - profile.profile = media::VP8PROFILE_MAIN; + profile.profile = media::VP8PROFILE_ANY; profile.max_resolution.SetSize(1920, 1088); profile.max_framerate.numerator = 30; profile.max_framerate.denominator = 1; diff --git a/content/renderer/media/rtc_video_decoder.cc b/content/renderer/media/rtc_video_decoder.cc index 4e4b319..1658970 100644 --- a/content/renderer/media/rtc_video_decoder.cc +++ b/content/renderer/media/rtc_video_decoder.cc @@ -118,7 +118,7 @@ scoped_ptr<RTCVideoDecoder> RTCVideoDecoder::Create( media::VideoCodecProfile profile; switch (type) { case webrtc::kVideoCodecVP8: - profile = media::VP8PROFILE_MAIN; + profile = media::VP8PROFILE_ANY; break; default: DVLOG(2) << "Video codec not supported:" << type; diff --git a/content/renderer/media/rtc_video_encoder_factory.cc b/content/renderer/media/rtc_video_encoder_factory.cc index 777d69f..e9c1578 100644 --- a/content/renderer/media/rtc_video_encoder_factory.cc +++ b/content/renderer/media/rtc_video_encoder_factory.cc @@ -48,7 +48,7 @@ media::VideoCodecProfile WebRTCCodecToVideoCodecProfile( webrtc::VideoCodecType type) { switch (type) { case webrtc::kVideoCodecVP8: - return media::VP8PROFILE_MAIN; + return media::VP8PROFILE_ANY; case webrtc::kVideoCodecGeneric: return media::H264PROFILE_MAIN; default: diff --git a/content/renderer/pepper/content_decryptor_delegate.cc b/content/renderer/pepper/content_decryptor_delegate.cc index 8692c1c..e1b0b1b 100644 --- a/content/renderer/pepper/content_decryptor_delegate.cc +++ b/content/renderer/pepper/content_decryptor_delegate.cc @@ -161,10 +161,8 @@ PP_VideoCodec MediaVideoCodecToPpVideoCodec(media::VideoCodec codec) { PP_VideoCodecProfile MediaVideoCodecProfileToPpVideoCodecProfile( media::VideoCodecProfile profile) { switch (profile) { - // TODO(xhwang): VP8 and VP9 do not have profiles. Clean up - // media::VideoCodecProfile and remove these two cases. - case media::VP8PROFILE_MAIN: - case media::VP9PROFILE_MAIN: + case media::VP8PROFILE_ANY: + case media::VP9PROFILE_ANY: return PP_VIDEOCODECPROFILE_NOT_NEEDED; case media::H264PROFILE_BASELINE: return PP_VIDEOCODECPROFILE_H264_BASELINE; diff --git a/content/renderer/pepper/pepper_video_decoder_host.cc b/content/renderer/pepper/pepper_video_decoder_host.cc index 4fc2d2c..fdb5cc3 100644 --- a/content/renderer/pepper/pepper_video_decoder_host.cc +++ b/content/renderer/pepper/pepper_video_decoder_host.cc @@ -53,10 +53,10 @@ media::VideoCodecProfile PepperToMediaVideoProfile(PP_VideoProfile profile) { return media::H264PROFILE_STEREOHIGH; case PP_VIDEOPROFILE_H264MULTIVIEWHIGH: return media::H264PROFILE_MULTIVIEWHIGH; - case PP_VIDEOPROFILE_VP8MAIN: - return media::VP8PROFILE_MAIN; - case PP_VIDEOPROFILE_VP9MAIN: - return media::VP9PROFILE_MAIN; + case PP_VIDEOPROFILE_VP8_ANY: + return media::VP8PROFILE_ANY; + case PP_VIDEOPROFILE_VP9_ANY: + return media::VP9PROFILE_ANY; // No default case, to catch unhandled PP_VideoProfile values. } diff --git a/content/renderer/pepper/ppb_video_decoder_impl.cc b/content/renderer/pepper/ppb_video_decoder_impl.cc index 01be7b7..f52d423 100644 --- a/content/renderer/pepper/ppb_video_decoder_impl.cc +++ b/content/renderer/pepper/ppb_video_decoder_impl.cc @@ -65,8 +65,8 @@ media::VideoCodecProfile PPToMediaProfile( return media::H264PROFILE_STEREOHIGH; case PP_VIDEODECODER_H264PROFILE_MULTIVIEWHIGH: return media::H264PROFILE_MULTIVIEWHIGH; - case PP_VIDEODECODER_VP8PROFILE_MAIN: - return media::VP8PROFILE_MAIN; + case PP_VIDEODECODER_VP8PROFILE_ANY: + return media::VP8PROFILE_ANY; default: return media::VIDEO_CODEC_PROFILE_UNKNOWN; } |