summaryrefslogtreecommitdiffstats
path: root/content
diff options
context:
space:
mode:
authorsadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-11-20 08:27:11 +0000
committersadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-11-20 08:27:11 +0000
commit226fe374de648b1b3523c9ee220c54a3e9f76a6f (patch)
tree4eb42669b2c7dc7aa09a81dfa6e1959a269bdffd /content
parentccf17a5123367f21d6a6589048378d6952a825be (diff)
downloadchromium_src-226fe374de648b1b3523c9ee220c54a3e9f76a6f.zip
chromium_src-226fe374de648b1b3523c9ee220c54a3e9f76a6f.tar.gz
chromium_src-226fe374de648b1b3523c9ee220c54a3e9f76a6f.tar.bz2
overscroll-aura: Discard synthetic mouse-move events during a trackpad overscroll.
As the overscroll is handled during scroll events from the trackpad, the RWHVA window is transformed. This transform triggers a synthetic mouse-move event to be generated (by the aura RootWindow). But this event interferes with the overscroll gesture. So, ignore such synthetic mouse-move events if an overscroll gesture is in progress. BUG=160668 Review URL: https://codereview.chromium.org/11411059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168762 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
-rw-r--r--content/browser/renderer_host/render_widget_host_view_aura.cc15
1 files changed, 15 insertions, 0 deletions
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 9af6457..c8da65b 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -13,6 +13,7 @@
#include "base/string_number_conversions.h"
#include "content/browser/renderer_host/backing_store_aura.h"
#include "content/browser/renderer_host/dip_util.h"
+#include "content/browser/renderer_host/overscroll_controller.h"
#include "content/browser/renderer_host/render_view_host_delegate.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/browser/renderer_host/ui_events_helper.h"
@@ -1569,6 +1570,20 @@ ui::EventResult RenderWidgetHostViewAura::OnMouseEvent(ui::MouseEvent* event) {
return ui::ER_UNHANDLED;
}
+ // As the overscroll is handled during scroll events from the trackpad, the
+ // RWHVA window is transformed by the overscroll controller. This transform
+ // triggers a synthetic mouse-move event to be generated (by the aura
+ // RootWindow). But this event interferes with the overscroll gesture. So,
+ // ignore such synthetic mouse-move events if an overscroll gesture is in
+ // progress.
+ if (host_->overscroll_controller() &&
+ host_->overscroll_controller()->overscroll_mode() != OVERSCROLL_NONE &&
+ event->flags() & ui::EF_IS_SYNTHESIZED &&
+ (event->type() == ui::ET_MOUSE_ENTERED ||
+ event->type() == ui::ET_MOUSE_MOVED)) {
+ return ui::ER_CONSUMED;
+ }
+
if (event->type() == ui::ET_MOUSEWHEEL) {
WebKit::WebMouseWheelEvent mouse_wheel_event =
MakeWebMouseWheelEvent(static_cast<ui::MouseWheelEvent*>(event));