diff options
| author | mad@chromium.org <mad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-24 17:37:26 +0000 |
|---|---|---|
| committer | mad@chromium.org <mad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-24 17:37:26 +0000 |
| commit | 3c17ae74d8ead9a9117c7837f832da0d02a225fa (patch) | |
| tree | 2931370090348f0e6b7b8c46f96722999e370b6d /content | |
| parent | f04fd2a1dd29de5e7b8e3269b5ed7118654550ef (diff) | |
| download | chromium_src-3c17ae74d8ead9a9117c7837f832da0d02a225fa.zip chromium_src-3c17ae74d8ead9a9117c7837f832da0d02a225fa.tar.gz chromium_src-3c17ae74d8ead9a9117c7837f832da0d02a225fa.tar.bz2 | |
Added an AddRef to prevent Bind to destroy a singleton.
Passing the this pointer of a singleton to Bind from the constructor will cause the singleton to go away... Unless we AddRef it previously.
BUG=157576
TBR=dmazzoni
Review URL: https://codereview.chromium.org/11267012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163859 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
| -rw-r--r-- | content/browser/accessibility/browser_accessibility_state_impl.cc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/content/browser/accessibility/browser_accessibility_state_impl.cc b/content/browser/accessibility/browser_accessibility_state_impl.cc index 1352867..df7dff9 100644 --- a/content/browser/accessibility/browser_accessibility_state_impl.cc +++ b/content/browser/accessibility/browser_accessibility_state_impl.cc @@ -49,6 +49,9 @@ BrowserAccessibilityStateImpl::BrowserAccessibilityStateImpl() // UpdateHistogram only takes a couple of milliseconds, but run it on // the FILE thread to guarantee there's no jank. + // And we need to AddRef() the leaky singleton so that Bind doesn't + // delete it prematurely. + AddRef(); content::BrowserThread::PostDelayedTask( content::BrowserThread::FILE, FROM_HERE, base::Bind(&BrowserAccessibilityStateImpl::UpdateHistogram, this), |