diff options
author | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-13 03:37:24 +0000 |
---|---|---|
committer | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-13 03:37:24 +0000 |
commit | a88bdaf1cbab8cea8813ade31c15c202482a21e5 (patch) | |
tree | c54e83f658d0ac781ad1913404a887d2955a1e87 /content | |
parent | 3c3455a7310fa80397d722c915a5baa6cd29e3a1 (diff) | |
download | chromium_src-a88bdaf1cbab8cea8813ade31c15c202482a21e5.zip chromium_src-a88bdaf1cbab8cea8813ade31c15c202482a21e5.tar.gz chromium_src-a88bdaf1cbab8cea8813ade31c15c202482a21e5.tar.bz2 |
[Coverity] Pass-by-val changed to pass-by-ref
TBR=sky@chromium.org
CID=103501
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9696009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126322 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
-rw-r--r-- | content/browser/renderer_host/clipboard_message_filter.cc | 8 | ||||
-rw-r--r-- | content/browser/renderer_host/clipboard_message_filter.h | 2 |
2 files changed, 6 insertions, 4 deletions
diff --git a/content/browser/renderer_host/clipboard_message_filter.cc b/content/browser/renderer_host/clipboard_message_filter.cc index 085d396..f859227 100644 --- a/content/browser/renderer_host/clipboard_message_filter.cc +++ b/content/browser/renderer_host/clipboard_message_filter.cc @@ -88,7 +88,7 @@ ClipboardMessageFilter::~ClipboardMessageFilter() { } void ClipboardMessageFilter::OnWriteObjectsSync( - ui::Clipboard::ObjectMap objects, + const ui::Clipboard::ObjectMap& objects, base::SharedMemoryHandle bitmap_handle) { DCHECK(base::SharedMemory::IsHandleValid(bitmap_handle)) << "Bad bitmap handle"; @@ -110,8 +110,10 @@ void ClipboardMessageFilter::OnWriteObjectsSync( base::Bind(&WriteObjectsHelper, base::Owned(long_living_objects))); #else // Splice the shared memory handle into the clipboard data. - ui::Clipboard::ReplaceSharedMemHandle(&objects, bitmap_handle, peer_handle()); - GetClipboard()->WriteObjects(ui::Clipboard::BUFFER_STANDARD, objects); + ui::Clipboard::ObjectMap objects_copy(objects); + ui::Clipboard::ReplaceSharedMemHandle(&objects_copy, + bitmap_handle, peer_handle()); + GetClipboard()->WriteObjects(ui::Clipboard::BUFFER_STANDARD, objects_copy); #endif } diff --git a/content/browser/renderer_host/clipboard_message_filter.h b/content/browser/renderer_host/clipboard_message_filter.h index b8607ea..f1b4f1d 100644 --- a/content/browser/renderer_host/clipboard_message_filter.h +++ b/content/browser/renderer_host/clipboard_message_filter.h @@ -27,7 +27,7 @@ class ClipboardMessageFilter : public content::BrowserMessageFilter { virtual ~ClipboardMessageFilter(); void OnWriteObjectsAsync(const ui::Clipboard::ObjectMap& objects); - void OnWriteObjectsSync(ui::Clipboard::ObjectMap objects, + void OnWriteObjectsSync(const ui::Clipboard::ObjectMap& objects, base::SharedMemoryHandle bitmap_handle); void OnGetSequenceNumber(const ui::Clipboard::Buffer buffer, |