diff options
| author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-23 23:32:55 +0000 |
|---|---|---|
| committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-23 23:32:55 +0000 |
| commit | bf42e2761eca34546bb0dbaa1f3ef1ac8cfce851 (patch) | |
| tree | 4bc074052807dc6e47cb606c4ef9337291bc5178 /content | |
| parent | 4202a91ea0ecca482af3812430e16ac975b4a3c1 (diff) | |
| download | chromium_src-bf42e2761eca34546bb0dbaa1f3ef1ac8cfce851.zip chromium_src-bf42e2761eca34546bb0dbaa1f3ef1ac8cfce851.tar.gz chromium_src-bf42e2761eca34546bb0dbaa1f3ef1ac8cfce851.tar.bz2 | |
content: Add missing virtual destructor to ZygoteHost.
Plus some other triviual fixes reported by cpplint.py.
TEST=content_unittests
R=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12042041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178420 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
| -rw-r--r-- | content/public/browser/child_process_data.h | 2 | ||||
| -rw-r--r-- | content/public/browser/color_chooser.h | 5 | ||||
| -rw-r--r-- | content/public/browser/devtools_manager.h | 3 | ||||
| -rw-r--r-- | content/public/browser/speech_recognition_event_listener.h | 4 | ||||
| -rw-r--r-- | content/public/browser/zygote_host_linux.h | 2 |
5 files changed, 10 insertions, 6 deletions
diff --git a/content/public/browser/child_process_data.h b/content/public/browser/child_process_data.h index 4b5a61c..c6db180 100644 --- a/content/public/browser/child_process_data.h +++ b/content/public/browser/child_process_data.h @@ -29,7 +29,7 @@ struct ChildProcessData { // The handle to the process. base::ProcessHandle handle; - ChildProcessData(content::ProcessType type) + explicit ChildProcessData(content::ProcessType type) : type(type), id(0), handle(base::kNullProcessHandle) { } }; diff --git a/content/public/browser/color_chooser.h b/content/public/browser/color_chooser.h index c8cd2b0..9b0bf40 100644 --- a/content/public/browser/color_chooser.h +++ b/content/public/browser/color_chooser.h @@ -17,7 +17,8 @@ class ColorChooser { static ColorChooser* Create(int identifier, WebContents* web_contents, SkColor initial_color); - ColorChooser(int identifier) : identifier_(identifier) {} + + explicit ColorChooser(int identifier) : identifier_(identifier) {} virtual ~ColorChooser() {} // Returns a unique identifier for this chooser. Identifiers are unique @@ -36,7 +37,7 @@ class ColorChooser { // Sets the selected color. virtual void SetSelectedColor(SkColor color) = 0; -private: + private: int identifier_; }; diff --git a/content/public/browser/devtools_manager.h b/content/public/browser/devtools_manager.h index fc44e4c..a9711d5 100644 --- a/content/public/browser/devtools_manager.h +++ b/content/public/browser/devtools_manager.h @@ -28,6 +28,8 @@ class CONTENT_EXPORT DevToolsManager { public: static DevToolsManager* GetInstance(); + virtual ~DevToolsManager() {} + // Routes devtools message from |from| client to corresponding // DevToolsAgentHost. virtual bool DispatchOnInspectorBackend(DevToolsClientHost* from, @@ -66,7 +68,6 @@ class CONTENT_EXPORT DevToolsManager { virtual void AddMessageToConsole(DevToolsAgentHost* agent_host, ConsoleMessageLevel level, const std::string& message) = 0; - }; } // namespace content diff --git a/content/public/browser/speech_recognition_event_listener.h b/content/public/browser/speech_recognition_event_listener.h index 653bfe7..9864912 100644 --- a/content/public/browser/speech_recognition_event_listener.h +++ b/content/public/browser/speech_recognition_event_listener.h @@ -60,8 +60,8 @@ class CONTENT_EXPORT SpeechRecognitionEventListener { // process and the |SpeechRecognizer| object can be freed if necessary. virtual void OnRecognitionEnd(int session_id) = 0; -protected: - virtual ~SpeechRecognitionEventListener() { } + protected: + virtual ~SpeechRecognitionEventListener() {} }; } // namespace content diff --git a/content/public/browser/zygote_host_linux.h b/content/public/browser/zygote_host_linux.h index d7ad6a4..2dd1f80 100644 --- a/content/public/browser/zygote_host_linux.h +++ b/content/public/browser/zygote_host_linux.h @@ -21,6 +21,8 @@ class ZygoteHost { // Returns the singleton instance. CONTENT_EXPORT static ZygoteHost* GetInstance(); + virtual ~ZygoteHost() {} + // Returns the pid of the Zygote process. virtual pid_t GetPid() const = 0; |