diff options
author | philipj <philipj@opera.com> | 2014-09-30 02:51:53 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-09-30 09:52:15 +0000 |
commit | b0e6f3fce92c7e2cc3df4a1d10d5508a48d1febc (patch) | |
tree | 9ab7cc580fd13aaa284e92fd3942b86fcbfc3d00 /content | |
parent | bf24e5ea0df583420cb420330efef7de12801875 (diff) | |
download | chromium_src-b0e6f3fce92c7e2cc3df4a1d10d5508a48d1febc.zip chromium_src-b0e6f3fce92c7e2cc3df4a1d10d5508a48d1febc.tar.gz chromium_src-b0e6f3fce92c7e2cc3df4a1d10d5508a48d1febc.tar.bz2 |
Switch from WebMediaPlayer::maxTimeSeekable() to seekable()
BUG=417669
Review URL: https://codereview.chromium.org/599103003
Cr-Commit-Position: refs/heads/master@{#297395}
Diffstat (limited to 'content')
4 files changed, 16 insertions, 11 deletions
diff --git a/content/renderer/media/android/webmediaplayer_android.cc b/content/renderer/media/android/webmediaplayer_android.cc index 155eea8..32f81d1 100644 --- a/content/renderer/media/android/webmediaplayer_android.cc +++ b/content/renderer/media/android/webmediaplayer_android.cc @@ -64,7 +64,6 @@ static const int kSDKVersionToSupportSecurityOriginCheck = 20; using blink::WebMediaPlayer; using blink::WebSize; using blink::WebString; -using blink::WebTimeRanges; using blink::WebURL; using gpu::gles2::GLES2Interface; using media::MediaPlayerAndroid; @@ -514,19 +513,25 @@ WebMediaPlayer::ReadyState WebMediaPlayerAndroid::readyState() const { return ready_state_; } -WebTimeRanges WebMediaPlayerAndroid::buffered() const { +blink::WebTimeRanges WebMediaPlayerAndroid::buffered() const { if (media_source_delegate_) return media_source_delegate_->Buffered(); return buffered_; } -double WebMediaPlayerAndroid::maxTimeSeekable() const { - // If we haven't even gotten to ReadyStateHaveMetadata yet then just - // return 0 so that the seekable range is empty. +blink::WebTimeRanges WebMediaPlayerAndroid::seekable() const { + // If we haven't even gotten to ReadyStateHaveMetadata yet then there + // are no seekable ranges. if (ready_state_ < WebMediaPlayer::ReadyStateHaveMetadata) - return 0.0; + return blink::WebTimeRanges(); - return duration(); + // If we have a duration then use [0, duration] as the seekable range. + const double seekable_end = duration(); + if (!seekable_end) + return blink::WebTimeRanges(); + + blink::WebTimeRange seekable_range(0.0, seekable_end); + return blink::WebTimeRanges(&seekable_range, 1); } bool WebMediaPlayerAndroid::didLoadingProgress() { diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h index 709eeea..92a94a3 100644 --- a/content/renderer/media/android/webmediaplayer_android.h +++ b/content/renderer/media/android/webmediaplayer_android.h @@ -112,7 +112,7 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer, virtual void requestRemotePlayback(); virtual void requestRemotePlaybackControl(); virtual blink::WebTimeRanges buffered() const; - virtual double maxTimeSeekable() const; + virtual blink::WebTimeRanges seekable() const; // Poster image, as defined in the <video> element. virtual void setPoster(const blink::WebURL& poster) OVERRIDE; diff --git a/content/renderer/media/webmediaplayer_ms.cc b/content/renderer/media/webmediaplayer_ms.cc index 6d94cd1..cc7f337 100644 --- a/content/renderer/media/webmediaplayer_ms.cc +++ b/content/renderer/media/webmediaplayer_ms.cc @@ -309,9 +309,9 @@ blink::WebTimeRanges WebMediaPlayerMS::buffered() const { return buffered_; } -double WebMediaPlayerMS::maxTimeSeekable() const { +blink::WebTimeRanges WebMediaPlayerMS::seekable() const { DCHECK(thread_checker_.CalledOnValidThread()); - return 0.0; + return blink::WebTimeRanges(); } bool WebMediaPlayerMS::didLoadingProgress() { diff --git a/content/renderer/media/webmediaplayer_ms.h b/content/renderer/media/webmediaplayer_ms.h index eb67d3d..975218f 100644 --- a/content/renderer/media/webmediaplayer_ms.h +++ b/content/renderer/media/webmediaplayer_ms.h @@ -76,7 +76,7 @@ class WebMediaPlayerMS virtual void setVolume(double volume); virtual void setPreload(blink::WebMediaPlayer::Preload preload); virtual blink::WebTimeRanges buffered() const; - virtual double maxTimeSeekable() const; + virtual blink::WebTimeRanges seekable() const; // Methods for painting. virtual void paint(blink::WebCanvas* canvas, |