diff options
author | rickyz <rickyz@chromium.org> | 2015-02-02 16:32:22 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-02-03 00:33:34 +0000 |
commit | 487353e4abfc8902439be6aed288adcfb9ece9e3 (patch) | |
tree | e812c6fc4d957f68ff409e2f621bc9b28ddb587a /content | |
parent | b38518b56959aa20926582bc8030e8835007c3d5 (diff) | |
download | chromium_src-487353e4abfc8902439be6aed288adcfb9ece9e3.zip chromium_src-487353e4abfc8902439be6aed288adcfb9ece9e3.tar.gz chromium_src-487353e4abfc8902439be6aed288adcfb9ece9e3.tar.bz2 |
Pass the size of the array to GetModuleFileName.
TCHAR may be a WCHAR, so sizeof would allow GetModuleFileName to write
twice the size of the buffer.
Thanks to Ilya Berdichevsky for the bug and fix.
BUG=446464
Review URL: https://codereview.chromium.org/898493003
Cr-Commit-Position: refs/heads/master@{#314223}
Diffstat (limited to 'content')
-rw-r--r-- | content/browser/accessibility/browser_accessibility_state_impl_win.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/content/browser/accessibility/browser_accessibility_state_impl_win.cc b/content/browser/accessibility/browser_accessibility_state_impl_win.cc index 28f05e0..ddce50e 100644 --- a/content/browser/accessibility/browser_accessibility_state_impl_win.cc +++ b/content/browser/accessibility/browser_accessibility_state_impl_win.cc @@ -8,6 +8,7 @@ #include <psapi.h> #include "base/files/file_path.h" +#include "base/macros.h" #include "base/metrics/histogram.h" #include "base/strings/string_util.h" @@ -56,7 +57,7 @@ void BrowserAccessibilityStateImpl::UpdatePlatformSpecificHistograms() { size_t module_count = bytes_required / sizeof(HMODULE); for (size_t i = 0; i < module_count; i++) { TCHAR filename[MAX_PATH]; - GetModuleFileName(modules[i], filename, sizeof(filename)); + GetModuleFileName(modules[i], filename, arraysize(filename)); base::string16 module_name(base::FilePath(filename).BaseName().value()); if (LowerCaseEqualsASCII(module_name, "fsdomsrv.dll")) jaws = true; |