diff options
| author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-25 13:54:38 +0000 |
|---|---|---|
| committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-25 13:54:38 +0000 |
| commit | 8da4b181bb0e611e1f6ce2880b5ebcfec7efa99f (patch) | |
| tree | 2981a415045b6475c27fff558d1213459c7fbe7a /content | |
| parent | 06b8914b3a620f1d7d16c52422fec03116fd9c7b (diff) | |
| download | chromium_src-8da4b181bb0e611e1f6ce2880b5ebcfec7efa99f.zip chromium_src-8da4b181bb0e611e1f6ce2880b5ebcfec7efa99f.tar.gz chromium_src-8da4b181bb0e611e1f6ce2880b5ebcfec7efa99f.tar.bz2 | |
Do not inherit from std::vector.
vector does not have a virtual destructor, see Item 7 from of Effective STL from
Scott Meyers for a detailed explanation.
BUG=135335
R=markusheintz@chromium.org,willchan@chromium.org
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10796081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148315 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content')
| -rw-r--r-- | content/browser/renderer_host/render_message_filter.h | 2 | ||||
| -rw-r--r-- | content/browser/renderer_host/resource_dispatcher_host_impl.h | 2 | ||||
| -rw-r--r-- | content/public/browser/content_browser_client.h | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/content/browser/renderer_host/render_message_filter.h b/content/browser/renderer_host/render_message_filter.h index 51eed1bf..10d2b92 100644 --- a/content/browser/renderer_host/render_message_filter.h +++ b/content/browser/renderer_host/render_message_filter.h @@ -21,6 +21,7 @@ #include "content/browser/renderer_host/resource_dispatcher_host_impl.h" #include "content/public/browser/browser_message_filter.h" #include "media/base/channel_layout.h" +#include "net/cookies/canonical_cookie.h" #include "third_party/WebKit/Source/WebKit/chromium/public/WebPopupType.h" #include "ui/gfx/native_widget_types.h" #include "ui/surface/transport_dib.h" @@ -52,7 +53,6 @@ struct MediaLogEvent; } namespace net { -class CookieList; class URLRequestContextGetter; } diff --git a/content/browser/renderer_host/resource_dispatcher_host_impl.h b/content/browser/renderer_host/resource_dispatcher_host_impl.h index 0b75399..83fe21d 100644 --- a/content/browser/renderer_host/resource_dispatcher_host_impl.h +++ b/content/browser/renderer_host/resource_dispatcher_host_impl.h @@ -32,6 +32,7 @@ #include "content/public/browser/notification_types.h" #include "content/public/browser/resource_dispatcher_host.h" #include "ipc/ipc_message.h" +#include "net/cookies/canonical_cookie.h" #include "net/url_request/url_request.h" #include "webkit/glue/resource_type.h" @@ -43,7 +44,6 @@ struct ResourceHostMsg_Request; struct ViewMsg_SwapOut_Params; namespace net { -class CookieList; class URLRequestJobFactory; } diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h index 9fb5a4d..01b26e1 100644 --- a/content/public/browser/content_browser_client.h +++ b/content/public/browser/content_browser_client.h @@ -12,6 +12,7 @@ #include "base/callback_forward.h" #include "content/public/common/content_client.h" #include "content/public/common/window_container_type.h" +#include "net/cookies/canonical_cookie.h" #include "third_party/WebKit/Source/WebKit/chromium/public/WebNotificationPresenter.h" #if defined(OS_POSIX) && !defined(OS_MACOSX) @@ -37,7 +38,6 @@ class ImageSkia; } namespace net { -class CookieList; class CookieOptions; class HttpNetworkSession; class NetLog; |