diff options
author | Yash Malik <ymalik@google.com> | 2016-02-23 15:06:23 -0500 |
---|---|---|
committer | Yash Malik <ymalik@google.com> | 2016-02-23 20:08:04 +0000 |
commit | 6fa68739e94ac02e8b2363b36eca05b9591ded0f (patch) | |
tree | 55941e747bfe4b9aaccd15f7a25a9404a23b5770 /content | |
parent | 06895c9421d30cb5da037b861c9d0a7b87771220 (diff) | |
download | chromium_src-6fa68739e94ac02e8b2363b36eca05b9591ded0f.zip chromium_src-6fa68739e94ac02e8b2363b36eca05b9591ded0f.tar.gz chromium_src-6fa68739e94ac02e8b2363b36eca05b9591ded0f.tar.bz2 |
Reverting changes that made window.scroll properties relative to the layout viewport.
Reason for revert:
Broke a bunch of sites that relied on visual viewport coordinates
(see www.crbug.com/571297). Reverting temporary until a new api that provides visual
viewport coordinates is made available to developers.
Revert "Make window.scroll properties relative to the layout viewport by default."
This reverts commit f75faf53de4a5c59269143b6edbfc6dc40c7fb33.
Revert "Remove plumbing for the inert-visual-viewport flag."
This reverts commit 58d42ae1d6690a9f625e23f160b346e9cebeab01.
TBR=avi@chromium.org,kenrb@chromium.org
BUG=571297
Review URL: https://codereview.chromium.org/1712743002
Cr-Commit-Position: refs/heads/master@{#376742}
(cherry picked from commit 835268c26a1f84e944b70d69703a54c4cb50bc5b)
Review URL: https://codereview.chromium.org/1724103002 .
Cr-Commit-Position: refs/branch-heads/2623@{#475}
Cr-Branched-From: 92d77538a86529ca35f9220bd3cd512cbea1f086-refs/heads/master@{#369907}
Diffstat (limited to 'content')
-rw-r--r-- | content/browser/renderer_host/render_process_host_impl.cc | 1 | ||||
-rw-r--r-- | content/browser/renderer_host/render_view_host_impl.cc | 3 | ||||
-rw-r--r-- | content/public/common/common_param_traits_macros.h | 1 | ||||
-rw-r--r-- | content/public/common/content_switches.cc | 3 | ||||
-rw-r--r-- | content/public/common/content_switches.h | 1 | ||||
-rw-r--r-- | content/public/common/web_preferences.cc | 1 | ||||
-rw-r--r-- | content/public/common/web_preferences.h | 1 | ||||
-rw-r--r-- | content/renderer/render_view_impl.cc | 2 |
8 files changed, 13 insertions, 0 deletions
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc index 67f45e6..bfba388 100644 --- a/content/browser/renderer_host/render_process_host_impl.cc +++ b/content/browser/renderer_host/render_process_host_impl.cc @@ -1430,6 +1430,7 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer( switches::kForceDisplayList2dCanvas, switches::kForceOverlayFullscreenVideo, switches::kFullMemoryCrashReport, + switches::kInertVisualViewport, switches::kIPCConnectionTimeout, switches::kJavaScriptFlags, switches::kLoggingLevel, diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc index 5916c11..f8175ab 100644 --- a/content/browser/renderer_host/render_view_host_impl.cc +++ b/content/browser/renderer_host/render_view_host_impl.cc @@ -441,6 +441,9 @@ WebPreferences RenderViewHostImpl::ComputeWebkitPrefs() { atoi(command_line.GetSwitchValueASCII( switches::kAcceleratedCanvas2dMSAASampleCount).c_str()); + prefs.inert_visual_viewport = + command_line.HasSwitch(switches::kInertVisualViewport); + prefs.pinch_overlay_scrollbar_thickness = 10; prefs.use_solid_color_scrollbars = ui::IsOverlayScrollbarEnabled(); diff --git a/content/public/common/common_param_traits_macros.h b/content/public/common/common_param_traits_macros.h index e3efceb..a1917f5 100644 --- a/content/public/common/common_param_traits_macros.h +++ b/content/public/common/common_param_traits_macros.h @@ -145,6 +145,7 @@ IPC_STRUCT_TRAITS_BEGIN(content::WebPreferences) IPC_STRUCT_TRAITS_MEMBER(webaudio_enabled) IPC_STRUCT_TRAITS_MEMBER(experimental_webgl_enabled) IPC_STRUCT_TRAITS_MEMBER(pepper_3d_enabled) + IPC_STRUCT_TRAITS_MEMBER(inert_visual_viewport) IPC_STRUCT_TRAITS_MEMBER(pinch_overlay_scrollbar_thickness) IPC_STRUCT_TRAITS_MEMBER(use_solid_color_scrollbars) IPC_STRUCT_TRAITS_MEMBER(flash_3d_enabled) diff --git a/content/public/common/content_switches.cc b/content/public/common/content_switches.cc index b7d4010e..1fe03b0 100644 --- a/content/public/common/content_switches.cc +++ b/content/public/common/content_switches.cc @@ -573,6 +573,9 @@ const char kIgnoreCertificateErrors[] = "ignore-certificate-errors"; // Ignores GPU blacklist. const char kIgnoreGpuBlacklist[] = "ignore-gpu-blacklist"; +// Makes all APIs reflect the layout viewport. +const char kInertVisualViewport[] = "inert-visual-viewport"; + // Run the GPU process as a thread in the browser process. const char kInProcessGPU[] = "in-process-gpu"; diff --git a/content/public/common/content_switches.h b/content/public/common/content_switches.h index 45297bb..1174c61 100644 --- a/content/public/common/content_switches.h +++ b/content/public/common/content_switches.h @@ -167,6 +167,7 @@ extern const char kGpuVendorID[]; CONTENT_EXPORT extern const char kHostResolverRules[]; CONTENT_EXPORT extern const char kIgnoreCertificateErrors[]; CONTENT_EXPORT extern const char kIgnoreGpuBlacklist[]; +CONTENT_EXPORT extern const char kInertVisualViewport[]; CONTENT_EXPORT extern const char kInProcessGPU[]; CONTENT_EXPORT extern const char kIPCConnectionTimeout[]; CONTENT_EXPORT extern const char kJavaScriptFlags[]; diff --git a/content/public/common/web_preferences.cc b/content/public/common/web_preferences.cc index 8ec979c..68ccbb4 100644 --- a/content/public/common/web_preferences.cc +++ b/content/public/common/web_preferences.cc @@ -173,6 +173,7 @@ WebPreferences::WebPreferences() use_solid_color_scrollbars(false), navigate_on_drag_drop(true), v8_cache_options(V8_CACHE_OPTIONS_DEFAULT), + inert_visual_viewport(false), cookie_enabled(true), pepper_accelerated_video_decode_enabled(false), animation_policy(IMAGE_ANIMATION_POLICY_ALLOWED), diff --git a/content/public/common/web_preferences.h b/content/public/common/web_preferences.h index 9926fc6..b784443 100644 --- a/content/public/common/web_preferences.h +++ b/content/public/common/web_preferences.h @@ -174,6 +174,7 @@ struct CONTENT_EXPORT WebPreferences { bool use_solid_color_scrollbars; bool navigate_on_drag_drop; V8CacheOptions v8_cache_options; + bool inert_visual_viewport; // This flags corresponds to a Page's Settings' setCookieEnabled state. It // only controls whether or not the "document.cookie" field is properly diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc index 2f80795..c2c266c 100644 --- a/content/renderer/render_view_impl.cc +++ b/content/renderer/render_view_impl.cc @@ -1037,6 +1037,8 @@ void RenderView::ApplyWebPreferences(const WebPreferences& prefs, settings->setSupportsMultipleWindows(prefs.supports_multiple_windows); + settings->setInertVisualViewport(prefs.inert_visual_viewport); + settings->setSmartInsertDeleteEnabled(prefs.smart_insert_delete_enabled); settings->setSpatialNavigationEnabled(prefs.spatial_navigation_enabled); |