[Sync] Fix Session's handling of windows.

We previously made some false assumptions about the order of window id's, and
freed memory for windows inappropriately. This would lead to memory corruption,
usually seen in the form of accesses to bad TabNavigation objects in the
session model associator. This patch completely rewrites how
we handle synced windows. Because there's no real order to windows, we now
store them in a map. In addition, because tabs can be moved between windows
and we aren't explicitly told which windows were closed or which tabs were
closed, we now have explicit tracking of the usage of windows and tabs, coupled
with a garbage collection phase that frees those tabs/windows that weren't
used during the tracking (see SyncedSessionTracker::ResetSessionTracking and
CleanupSession methods).

Due to the change in how we store windows, the integration tests and the
sessions ui had to be modified, but the real changes are within the session
model associator and the synced session tracker. Also, undisabled a test
that should be working.

BUG=94124, 81104
TEST=unit_tests; Opening windows with valid tabs, waiting for sync, closing
those windows.


Review URL: http://codereview.chromium.org/7966020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103878 0039d316-1c4b-4281-b951-d872f2087c98

0 files changed, 0 insertions, 0 deletions