Start refactoring to reduce executable type knowledge.

This creates executable detection functions, a globally shared enum for
describing an executable type, and reduces the number of classes and
locations with executable specific knowledge.

These changes, along with moving architecture specific classes into their
own files should make it easier to produce special purpose clients that
only contain the code required to apply their own form of patch.

DisassemblerWin32EXE, ImagePE, CourgetteWin32X86PatchGenerator, and
CourgetteWin32X86Patcher, and ensemble handling are all heavily affected here.

This should have no effect on the behavior of the system yet, and is instead
all prep-work.

BUG=None
TEST=Unittests


Review URL: http://codereview.chromium.org/7920004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103879 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 2 insertions, 9 deletions

diff --git a/courgette/disassembler.h b/courgette/disassembler.h
index fa7c908..bef1a90 100644
--- a/courgette/disassembler.h
+++ b/courgette/disassembler.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -14,21 +14,14 @@ class PEInfo;
 
 class Disassembler {
  public:
-  // Factory methods for making disassemblers for various kinds of executables.
-  // We have only one so far.
-
-  static Disassembler* MakeDisassemberWin32X86(PEInfo* pe_info);
+  virtual ~Disassembler() {}
 
   // Disassembles the item passed to the factory method into the output
   // parameter 'program'.
   virtual bool Disassemble(AssemblyProgram* program) = 0;
 
-  // Deletes 'this' disassembler.
-  virtual void Destroy() = 0;
-
  protected:
   Disassembler() {}
-  virtual ~Disassembler() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(Disassembler);