diff options
author | dgarrett@chromium.org <dgarrett@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-23 03:24:15 +0000 |
---|---|---|
committer | dgarrett@chromium.org <dgarrett@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-23 03:24:15 +0000 |
commit | 19868d291fd225ebd30ef74eed759f1e4676a06a (patch) | |
tree | f8753f974946060b5b5f6703fcbf43a6974229f2 /courgette | |
parent | a4c227c826c79f594d5f29864738bb40e99672bb (diff) | |
download | chromium_src-19868d291fd225ebd30ef74eed759f1e4676a06a.zip chromium_src-19868d291fd225ebd30ef74eed759f1e4676a06a.tar.gz chromium_src-19868d291fd225ebd30ef74eed759f1e4676a06a.tar.bz2 |
Revert 102428 - Add a backwards compatibility unittest.
This is a resubmit of CL 7915007.
BUG=None
TEST=New Unittest
Review URL: http://codereview.chromium.org/7976035
TBR=dgarrett@chromium.org
Review URL: http://codereview.chromium.org/7972027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102434 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'courgette')
-rw-r--r-- | courgette/courgette.gyp | 3 | ||||
-rw-r--r-- | courgette/testdata/setup1-setup2.v1.patch | 0 | ||||
-rw-r--r-- | courgette/versioning_unittest.cc | 83 |
3 files changed, 1 insertions, 85 deletions
diff --git a/courgette/courgette.gyp b/courgette/courgette.gyp index 5a183e8..e9fa170 100644 --- a/courgette/courgette.gyp +++ b/courgette/courgette.gyp @@ -1,4 +1,4 @@ -# Copyright (c) 2011 The Chromium Authors. All rights reserved. +# Copyright (c) 2009 The Chromium Authors. All rights reserved. # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. @@ -92,7 +92,6 @@ 'image_info_unittest.cc', 'run_all_unittests.cc', 'streams_unittest.cc', - 'versioning_unittest.cc', 'third_party/paged_array_unittest.cc' ], 'dependencies': [ diff --git a/courgette/testdata/setup1-setup2.v1.patch b/courgette/testdata/setup1-setup2.v1.patch deleted file mode 100644 index e69de29..0000000 --- a/courgette/testdata/setup1-setup2.v1.patch +++ /dev/null diff --git a/courgette/versioning_unittest.cc b/courgette/versioning_unittest.cc deleted file mode 100644 index 34a6ca1..0000000 --- a/courgette/versioning_unittest.cc +++ /dev/null @@ -1,83 +0,0 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include <string> - -#include "base/path_service.h" -#include "base/file_util.h" -#include "base/string_util.h" - -#include "courgette/courgette.h" -#include "courgette/streams.h" - -#include "testing/gtest/include/gtest/gtest.h" - -class VersioningTest : public testing::Test { - public: - void TestApplyingOldPatch(const char* src_file, - const char* patch_file, - const char* expected_file) const; - - private: - void SetUp() { - PathService::Get(base::DIR_SOURCE_ROOT, &testdata_dir_); - testdata_dir_ = testdata_dir_.AppendASCII("courgette"); - testdata_dir_ = testdata_dir_.AppendASCII("testdata"); - } - - void TearDown() { } - - // Returns contents of |file_name| as uninterprested bytes stored in a string. - std::string FileContents(const char* file_name) const; - - FilePath testdata_dir_; // Full path name of testdata directory -}; - -// Reads a test file into a string. -std::string VersioningTest::FileContents(const char* file_name) const { - FilePath file_path = testdata_dir_; - file_path = file_path.AppendASCII(file_name); - std::string file_contents; - EXPECT_TRUE(file_util::ReadFileToString(file_path, &file_contents)); - return file_contents; -} - -void VersioningTest::TestApplyingOldPatch(const char* src_file, - const char* patch_file, - const char* expected_file) const { - - std::string old_buffer = FileContents(src_file); - std::string new_buffer = FileContents(patch_file); - std::string expected_buffer = FileContents(expected_file); - - courgette::SourceStream old_stream; - courgette::SourceStream patch_stream; - old_stream.Init(old_buffer); - patch_stream.Init(new_buffer); - - courgette::SinkStream generated_stream; - - courgette::Status status = - courgette::ApplyEnsemblePatch(&old_stream, - &patch_stream, - &generated_stream); - - EXPECT_EQ(status, courgette::C_OK); - - size_t expected_length = expected_buffer.size(); - size_t generated_length = generated_stream.Length(); - - EXPECT_EQ(generated_length, expected_length); - EXPECT_EQ(0, memcmp(generated_stream.Buffer(), - expected_buffer.c_str(), - expected_length)); -} - - -TEST_F(VersioningTest, All) { - TestApplyingOldPatch("setup1.exe", "setup1-setup2.v1.patch", "setup2.exe"); - - // We also need a way to test that newly generated patches are appropriately - // applicable by older clients... not sure of the best way to do that. -} |