summaryrefslogtreecommitdiffstats
path: root/courgette
diff options
context:
space:
mode:
authorwfh <wfh@chromium.org>2014-10-13 23:12:07 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-14 06:12:26 +0000
commit6e7226194f0c3390dd07829098f9da132bca03c5 (patch)
treea1b91db8e5802b1fb7ce38e5a0e28cf19f8f5a3c /courgette
parentd7e09730fb84eaf611a5a0edac79e9ca66033c5c (diff)
downloadchromium_src-6e7226194f0c3390dd07829098f9da132bca03c5.zip
chromium_src-6e7226194f0c3390dd07829098f9da132bca03c5.tar.gz
chromium_src-6e7226194f0c3390dd07829098f9da132bca03c5.tar.bz2
Re-enable ensemble tests on Windows Release builds.
This is only taking a long time on Debug, because of the additional iterator validators running on all the stl objects being used. BUG=101614 Review URL: https://codereview.chromium.org/647093002 Cr-Commit-Position: refs/heads/master@{#299437}
Diffstat (limited to 'courgette')
-rw-r--r--courgette/ensemble_unittest.cc21
1 files changed, 15 insertions, 6 deletions
diff --git a/courgette/ensemble_unittest.cc b/courgette/ensemble_unittest.cc
index e2f1198..b255ae9 100644
--- a/courgette/ensemble_unittest.cc
+++ b/courgette/ensemble_unittest.cc
@@ -6,6 +6,18 @@
#include "courgette/courgette.h"
#include "courgette/streams.h"
+#if defined(OS_WIN) && !defined(NDEBUG)
+// Ensemble tests still take too long on Debug Windows so disabling for now
+// TODO(dgarrett) http://code.google.com/p/chromium/issues/detail?id=101614
+#define MAYBE_PE DISABLED_PE
+#define MAYBE_PE64 DISABLED_PE64
+#define MAYBE_Elf32 DISABLED_Elf32
+#else
+#define MAYBE_PE PE
+#define MAYBE_PE64 PE64
+#define MAYBE_Elf32 Elf32
+#endif
+
class EnsembleTest : public BaseTest {
public:
@@ -103,17 +115,14 @@ void EnsembleTest::Pe64Ensemble() const {
TestEnsemble(src_bytes, tgt_bytes);
}
-// Ensemble tests still take too long on Windows so disabling for now
-// TODO(dgarrett) http://code.google.com/p/chromium/issues/detail?id=101614
-
-TEST_F(EnsembleTest, DISABLED_PE) {
+TEST_F(EnsembleTest, MAYBE_PE) {
PeEnsemble();
}
-TEST_F(EnsembleTest, DISABLED_PE64) {
+TEST_F(EnsembleTest, MAYBE_PE64) {
Pe64Ensemble();
}
-TEST_F(EnsembleTest, DISABLED_Elf32) {
+TEST_F(EnsembleTest, MAYBE_Elf32) {
Elf32Ensemble();
}