diff options
| author | eroman <eroman@chromium.org> | 2014-11-11 11:57:54 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-11-11 19:58:31 +0000 |
| commit | 5a49bc9eb668725b1c52ce8458eb431b383d8ff7 (patch) | |
| tree | 880c7c871def64ed603553c35a83a1b5599c593d /crypto | |
| parent | 9b199faebfa69908859b9069cbb3e5b207c8e825 (diff) | |
| download | chromium_src-5a49bc9eb668725b1c52ce8458eb431b383d8ff7.zip chromium_src-5a49bc9eb668725b1c52ce8458eb431b383d8ff7.tar.gz chromium_src-5a49bc9eb668725b1c52ce8458eb431b383d8ff7.tar.bz2 | |
Cleanup: Don't check for negative values from EVP_DigestVerifyFinal.
(No longer a possibility in BoringSSL).
Review URL: https://codereview.chromium.org/707973007
Cr-Commit-Position: refs/heads/master@{#303700}
Diffstat (limited to 'crypto')
| -rw-r--r-- | crypto/signature_verifier_openssl.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/crypto/signature_verifier_openssl.cc b/crypto/signature_verifier_openssl.cc index 53637eb..84aa2ea 100644 --- a/crypto/signature_verifier_openssl.cc +++ b/crypto/signature_verifier_openssl.cc @@ -122,8 +122,7 @@ bool SignatureVerifier::VerifyFinal() { int rv = EVP_DigestVerifyFinal(verify_context_->ctx.get(), vector_as_array(&signature_), signature_.size()); - // rv is -1 if a DER-encoded ECDSA signature cannot be decoded correctly. - DCHECK_GE(rv, -1); + DCHECK_EQ(!!rv, rv); Reset(); return rv == 1; } |