diff options
| author | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-07 16:26:30 +0000 |
|---|---|---|
| committer | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-07 16:26:30 +0000 |
| commit | e184ccec44f19ae4f3beaef01d5e90753ff924e8 (patch) | |
| tree | 3859e788740a9641c5fa7f511f8f9a91ecf0b30d /dbus/bus.cc | |
| parent | 18da0fd59dfacb8d00f803103fdbdc556d5d6fe3 (diff) | |
| download | chromium_src-e184ccec44f19ae4f3beaef01d5e90753ff924e8.zip chromium_src-e184ccec44f19ae4f3beaef01d5e90753ff924e8.tar.gz chromium_src-e184ccec44f19ae4f3beaef01d5e90753ff924e8.tar.bz2 | |
Eliminate a timed wait from ExportedObject::HandleMessage().
Previouslly, we blocked in D-Bus thread until the method call is handled
in the UI thread. Turned out this was a bad idea, and caused a crash when
the UI thread is hanging (crosbug.com/21341).
This patch will eliminate the timed wait and incoming methods will be handled
completely asynchronously.
BUG=chromium-os:21341
TEST=run dbus_unittests under valgrind
Review URL: http://codereview.chromium.org/8175009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104497 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'dbus/bus.cc')
| -rw-r--r-- | dbus/bus.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/dbus/bus.cc b/dbus/bus.cc index 87fe9c7..843739c 100644 --- a/dbus/bus.cc +++ b/dbus/bus.cc @@ -390,7 +390,6 @@ bool Bus::SetUpAsyncOperations() { NULL); CHECK(success) << "Unable to allocate memory"; - // TODO(satorux): Timeout is not yet implemented. success = dbus_connection_set_timeout_functions(connection_, &Bus::OnAddTimeoutThunk, &Bus::OnRemoveTimeoutThunk, |