diff options
| author | hashimoto@chromium.org <hashimoto@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-23 06:55:22 +0000 |
|---|---|---|
| committer | hashimoto@chromium.org <hashimoto@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-23 06:55:22 +0000 |
| commit | ca72ff29277e39031e2b409e2a593b25d0066e8a (patch) | |
| tree | bfadc8aeb37312310f8743ae4ff5e9a631c1c625 /dbus/exported_object.cc | |
| parent | f9cb2108d32497ca7688db99f144e0dbe73537da (diff) | |
| download | chromium_src-ca72ff29277e39031e2b409e2a593b25d0066e8a.zip chromium_src-ca72ff29277e39031e2b409e2a593b25d0066e8a.tar.gz chromium_src-ca72ff29277e39031e2b409e2a593b25d0066e8a.tar.bz2 | |
Change setters of dbus::Message to return false instead of aborting on errors
With this change, we can safely return error for invalid object path and service name.
It still crashes on invalid method name and interface name if we use MethodCall::MethodCall for setting those parameters.
BUG=128967
TEST=dbus_unittests
Review URL: https://chromiumcodereview.appspot.com/10409065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138441 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'dbus/exported_object.cc')
| -rw-r--r-- | dbus/exported_object.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/dbus/exported_object.cc b/dbus/exported_object.cc index 7c4bada..f9ddb62 100644 --- a/dbus/exported_object.cc +++ b/dbus/exported_object.cc @@ -90,7 +90,7 @@ void ExportedObject::ExportMethod(const std::string& interface_name, void ExportedObject::SendSignal(Signal* signal) { // For signals, the object path should be set to the path to the sender // object, which is this exported object here. - signal->SetPath(object_path_); + CHECK(signal->SetPath(object_path_)); // Increment the reference count so we can safely reference the // underlying signal message until the signal sending is complete. This |