summaryrefslogtreecommitdiffstats
path: root/dbus/mock_unittest.cc
diff options
context:
space:
mode:
authordpapad@chromium.org <dpapad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-14 20:22:53 +0000
committerdpapad@chromium.org <dpapad@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-14 20:22:53 +0000
commit02743b707e2743cd0f0916e3b405191a48fa3947 (patch)
tree2b0c0be422f99a2e0dce81c6de92f9a8bc80b969 /dbus/mock_unittest.cc
parent7f58f3f417a0598ad796ca7de7b14a38252d91bd (diff)
downloadchromium_src-02743b707e2743cd0f0916e3b405191a48fa3947.zip
chromium_src-02743b707e2743cd0f0916e3b405191a48fa3947.tar.gz
chromium_src-02743b707e2743cd0f0916e3b405191a48fa3947.tar.bz2
Revert 121920 - dbus: add ObjectPath type
Rather than use std::string for object paths, add a dbus::ObjectPath type that wraps one while allowing more type-safety. This solves all sorts of issues with confusing object paths for strings, and allows us to do Properties code using templates disambiguating them from strings. BUG=chromium:109194 TEST=built and run tests Change-Id: Icaf6f19daea4af23a9d2ec0ed76d2cbd379d680e Review URL: http://codereview.chromium.org/9378039 TBR=keybuk@chromium.org Review URL: https://chromiumcodereview.appspot.com/9363045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121923 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'dbus/mock_unittest.cc')
-rw-r--r--dbus/mock_unittest.cc19
1 files changed, 8 insertions, 11 deletions
diff --git a/dbus/mock_unittest.cc b/dbus/mock_unittest.cc
index cf644df..022b03d 100644
--- a/dbus/mock_unittest.cc
+++ b/dbus/mock_unittest.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -11,7 +11,6 @@
#include "dbus/mock_bus.h"
#include "dbus/mock_object_proxy.h"
#include "dbus/mock_exported_object.h"
-#include "dbus/object_path.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -32,10 +31,9 @@ class MockTest : public testing::Test {
mock_bus_ = new dbus::MockBus(options);
// Create a mock proxy.
- mock_proxy_ = new dbus::MockObjectProxy(
- mock_bus_.get(),
- "org.chromium.TestService",
- dbus::ObjectPath("/org/chromium/TestObject"));
+ mock_proxy_ = new dbus::MockObjectProxy(mock_bus_.get(),
+ "org.chromium.TestService",
+ "/org/chromium/TestObject");
// Set an expectation so mock_proxy's CallMethodAndBlock() will use
// CreateMockProxyResponse() to return responses.
@@ -51,9 +49,8 @@ class MockTest : public testing::Test {
// Set an expectation so mock_bus's GetObjectProxy() for the given
// service name and the object path will return mock_proxy_.
- EXPECT_CALL(*mock_bus_, GetObjectProxy(
- "org.chromium.TestService",
- dbus::ObjectPath("/org/chromium/TestObject")))
+ EXPECT_CALL(*mock_bus_, GetObjectProxy("org.chromium.TestService",
+ "/org/chromium/TestObject"))
.WillOnce(Return(mock_proxy_.get()));
// ShutdownAndBlock() will be called in TearDown().
@@ -133,7 +130,7 @@ TEST_F(MockTest, CallMethodAndBlock) {
// Get an object proxy from the mock bus.
dbus::ObjectProxy* proxy = mock_bus_->GetObjectProxy(
"org.chromium.TestService",
- dbus::ObjectPath("/org/chromium/TestObject"));
+ "/org/chromium/TestObject");
// Create a method call.
dbus::MethodCall method_call("org.chromium.TestInterface", "Echo");
@@ -162,7 +159,7 @@ TEST_F(MockTest, CallMethod) {
// Get an object proxy from the mock bus.
dbus::ObjectProxy* proxy = mock_bus_->GetObjectProxy(
"org.chromium.TestService",
- dbus::ObjectPath("/org/chromium/TestObject"));
+ "/org/chromium/TestObject");
// Create a method call.
dbus::MethodCall method_call("org.chromium.TestInterface", "Echo");