diff options
author | dcheng <dcheng@chromium.org> | 2014-10-22 16:07:52 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-22 23:08:15 +0000 |
commit | b5aaf402eb4783b9f62de3ae8485edec343866cc (patch) | |
tree | e9f30bd26479007ce31da6833f81743109eba9b4 /device/serial/data_sink_receiver.cc | |
parent | 9cee6105930e94ad2abf2c004efb1d65c0759a0f (diff) | |
download | chromium_src-b5aaf402eb4783b9f62de3ae8485edec343866cc.zip chromium_src-b5aaf402eb4783b9f62de3ae8485edec343866cc.tar.gz chromium_src-b5aaf402eb4783b9f62de3ae8485edec343866cc.tar.bz2 |
Standardize usage of virtual/override/final in device/
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
TBR=keybuk@chromium.org
Review URL: https://codereview.chromium.org/663203007
Cr-Commit-Position: refs/heads/master@{#300790}
Diffstat (limited to 'device/serial/data_sink_receiver.cc')
-rw-r--r-- | device/serial/data_sink_receiver.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/device/serial/data_sink_receiver.cc b/device/serial/data_sink_receiver.cc index 767f036..3d52e48 100644 --- a/device/serial/data_sink_receiver.cc +++ b/device/serial/data_sink_receiver.cc @@ -44,15 +44,15 @@ class DataSinkReceiver::Buffer : public ReadOnlyBuffer { Buffer(scoped_refptr<DataSinkReceiver> receiver, const char* buffer, uint32_t buffer_size); - virtual ~Buffer(); + ~Buffer() override; void Cancel(int32_t error); // ReadOnlyBuffer overrides. - virtual const char* GetData() override; - virtual uint32_t GetSize() override; - virtual void Done(uint32_t bytes_read) override; - virtual void DoneWithError(uint32_t bytes_read, int32_t error) override; + const char* GetData() override; + uint32_t GetSize() override; + void Done(uint32_t bytes_read) override; + void DoneWithError(uint32_t bytes_read, int32_t error) override; private: // The DataSinkReceiver whose data pipe we are providing a view. |