diff options
author | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-01 07:10:05 +0000 |
---|---|---|
committer | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-01 07:10:05 +0000 |
commit | 6bd63d7d1c922bc73f58c5e5c10be0fa281a2178 (patch) | |
tree | 092fbfca803f682bb6cc45fea63e987a8d6cf59c /device | |
parent | f444609b1d0c185a726b2f38f9663bdd9b507079 (diff) | |
download | chromium_src-6bd63d7d1c922bc73f58c5e5c10be0fa281a2178.zip chromium_src-6bd63d7d1c922bc73f58c5e5c10be0fa281a2178.tar.gz chromium_src-6bd63d7d1c922bc73f58c5e5c10be0fa281a2178.tar.bz2 |
Revert 197518 "Move download filename determination into a separ..."
It has introduced a number of memory leaks in unit_tests that show up on both
Valgrind and HeapChecker bot and some of them are hard to suppress without
collateral false negatives.
> Move download filename determination into a separate class.
>
> * Extracts download filename determination into
> DownloadTargetDeterminer. The new class maintains state and observes
> the download. Doing so eliminates the need to pass state around as
> bound arguments.
>
> * Guarantees that the completion callback to
> DownloadManagerDelegate::DetermineDownloadTarget is always invoked,
> even if the download is interrupted on initialization. This is
> required for reliably resuming downloads.
>
> * The DownloadFilePicker always returns the virtual path for downloads
> to Drive. ChromeDownloadManagerDelegate can use it to keep track of
> the correct last selected directory for 'Save As' downloads.
>
> * Since no path subsubstituion is necessary during prompting,
> DownloadFilePickerChromeOS is no longer necessary.
>
> * Re-orders the sequence of events so that the user is prompted as early
> as possible. Expensive history database lookups won't introduce
> unnecssary jank.
>
> * History database lookups are only performed if the results of the
> lookup are necessary.
>
> * Downloads to Drive don't need the temporary local path to be
> determined twice when the default downloads directory is Drive.
>
> BUG=151618
> BUG=104335
>
> Review URL: https://chromiumcodereview.appspot.com/12850002
TBR=asanka@chromium.org
Review URL: https://codereview.chromium.org/14755003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197578 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'device')
0 files changed, 0 insertions, 0 deletions