diff options
| author | shawnsingh@google.com <shawnsingh@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-29 01:00:19 +0000 |
|---|---|---|
| committer | shawnsingh@google.com <shawnsingh@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-29 01:00:19 +0000 |
| commit | edc9183c42f56dbdedafb6455bb6ac71c97d7faf (patch) | |
| tree | 914ea5ded792c4b48728ede20e488c3155b2c686 /device | |
| parent | 8f1e35f3f703c9be068dda4aeb476b8c7b2ca48c (diff) | |
| download | chromium_src-edc9183c42f56dbdedafb6455bb6ac71c97d7faf.zip chromium_src-edc9183c42f56dbdedafb6455bb6ac71c97d7faf.tar.gz chromium_src-edc9183c42f56dbdedafb6455bb6ac71c97d7faf.tar.bz2 | |
Revert 214144 "Add PRESUBMIT check to cc to ensure that C++ std:..."
For some reason patch is causing a win7_aura failure, reverting
to investigate.
> Add PRESUBMIT check to cc to ensure that C++ std::abs is used
>
> Before this patch, it is possible to use abs() without the std::
> namespace qualifier, which may link to the C standard library
> implementation of abs(). Thus, someone using abs(float) may get
> wrong results because C standard version will convert the float
> to an int. This patch updates the occurrences of of abs() and
> fabs() in cc/ (though technically none were incorrect, thankfully)
> and adds a PRESUBMIT to enforce that all uses of abs from now on
> have an explicit std:: to resolve them correctly.
>
> BUG=261900
> R=enne@chromium.org
>
> Review URL: https://codereview.chromium.org/19835003
TBR=shawnsingh@google.com
Review URL: https://codereview.chromium.org/20992002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214149 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'device')
0 files changed, 0 insertions, 0 deletions