summaryrefslogtreecommitdiffstats
path: root/device
diff options
context:
space:
mode:
authorreillyg <reillyg@chromium.org>2014-10-29 05:34:47 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-29 12:35:34 +0000
commit47f8feca9708c2ac252ca5c6e2c59cafa4da6999 (patch)
tree558c06703e9cd470e0516f5bd6ded011d4d06d27 /device
parentd84534d316a5fa519123b3b04d5b39991fc2ef0e (diff)
downloadchromium_src-47f8feca9708c2ac252ca5c6e2c59cafa4da6999.zip
chromium_src-47f8feca9708c2ac252ca5c6e2c59cafa4da6999.tar.gz
chromium_src-47f8feca9708c2ac252ca5c6e2c59cafa4da6999.tar.bz2
Save USB device manufacturer and product strings for permission messages.
Store the manufacturer and product strings read from the USB devices so that they may be displayed in permission messages when the device is not connected. This unifies the way that devices are named in the USB device picker and in the extension permissions prompt. BUG=417516 Review URL: https://codereview.chromium.org/681783005 Cr-Commit-Position: refs/heads/master@{#301820}
Diffstat (limited to 'device')
-rw-r--r--device/usb/usb_device.h3
1 files changed, 3 insertions, 0 deletions
diff --git a/device/usb/usb_device.h b/device/usb/usb_device.h
index 7ea964c..8b8ec62 100644
--- a/device/usb/usb_device.h
+++ b/device/usb/usb_device.h
@@ -57,14 +57,17 @@ class UsbDevice : public base::RefCountedThreadSafe<UsbDevice> {
// Gets the manufacturer string of the device, or returns false.
// Blocking method. Must be called on FILE thread.
+ // TODO(reillyg): Make this available from the UI thread. crbug.com/427985
virtual bool GetManufacturer(base::string16* manufacturer) = 0;
// Gets the product string of the device, or returns false.
// Blocking method. Must be called on FILE thread.
+ // TODO(reillyg): Make this available from the UI thread. crbug.com/427985
virtual bool GetProduct(base::string16* product) = 0;
// Gets the serial number string of the device, or returns false.
// Blocking method. Must be called on FILE thread.
+ // TODO(reillyg): Make this available from the UI thread. crbug.com/427985
virtual bool GetSerialNumber(base::string16* serial) = 0;
void AddObserver(Observer* obs) { observer_list_.AddObserver(obs); }