diff options
| author | dgozman@chromium.org <dgozman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-18 12:31:44 +0000 |
|---|---|---|
| committer | dgozman@chromium.org <dgozman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-18 12:33:06 +0000 |
| commit | b50452f45eae2c6d857d638186ada82e20ebd4da (patch) | |
| tree | 22695c8f7ac537769d6efb297910a9359f84abe4 /extensions/browser/process_manager.cc | |
| parent | f8ceadbc79b56327f6f217d3478631896b9b6ee9 (diff) | |
| download | chromium_src-b50452f45eae2c6d857d638186ada82e20ebd4da.zip chromium_src-b50452f45eae2c6d857d638186ada82e20ebd4da.tar.gz chromium_src-b50452f45eae2c6d857d638186ada82e20ebd4da.tar.bz2 | |
[DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManager.
Previously, client used methods on DevToolsManager passing |this| to most of them.
Instead, it should hold a scoped_refptr to inspected DevToolsAgentHost and talk
to it directly. This creates a single clean entry point for the client, and allows
in the future to handle browser-wide protocol messages and debug multiple hosts at once.
BUG=401073
TBR=kalman@chromium.org
Review URL: https://codereview.chromium.org/449043002
Cr-Commit-Position: refs/heads/master@{#290236}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290236 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'extensions/browser/process_manager.cc')
| -rw-r--r-- | extensions/browser/process_manager.cc | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/extensions/browser/process_manager.cc b/extensions/browser/process_manager.cc index fe56315..6f0903f 100644 --- a/extensions/browser/process_manager.cc +++ b/extensions/browser/process_manager.cc @@ -16,7 +16,6 @@ #include "content/public/browser/browser_context.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/devtools_agent_host.h" -#include "content/public/browser/devtools_manager.h" #include "content/public/browser/notification_service.h" #include "content/public/browser/render_frame_host.h" #include "content/public/browser/render_process_host.h" @@ -286,8 +285,7 @@ ProcessManager::ProcessManager(BrowserContext* context, base::TimeDelta::FromMilliseconds(suspending_time_msec); } - content::DevToolsManager::GetInstance()->AddAgentStateCallback( - devtools_callback_); + content::DevToolsAgentHost::AddAgentStateCallback(devtools_callback_); OnKeepaliveImpulseCheck(); } @@ -295,8 +293,7 @@ ProcessManager::ProcessManager(BrowserContext* context, ProcessManager::~ProcessManager() { CloseBackgroundHosts(); DCHECK(background_hosts_.empty()); - content::DevToolsManager::GetInstance()->RemoveAgentStateCallback( - devtools_callback_); + content::DevToolsAgentHost::RemoveAgentStateCallback(devtools_callback_); } const ProcessManager::ViewSet ProcessManager::GetAllViews() const { |