diff options
author | treib <treib@chromium.org> | 2015-03-20 04:44:58 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-03-20 11:45:29 +0000 |
commit | f91b57ec449cf77cec413328b7fc6fc3f48e6fe6 (patch) | |
tree | 48b9b95db0a481b56f6aa490a515dbe8980f30b2 /extensions/test | |
parent | b7970f8e6fbdc5a6beacde42ffff72e226082534 (diff) | |
download | chromium_src-f91b57ec449cf77cec413328b7fc6fc3f48e6fe6.zip chromium_src-f91b57ec449cf77cec413328b7fc6fc3f48e6fe6.tar.gz chromium_src-f91b57ec449cf77cec413328b7fc6fc3f48e6fe6.tar.bz2 |
Extensions: Switch to new permission message system, part I
- Update lots of tests to check that the old and new system match.
- In the process, fix two small bugs in the new system.
- Rename PermissionsData::GetPermissionMessageStrings and GetPermissionMessageDetailsStrings to "*Legacy*", to match the corresponding methods in PermissionMessageProvider.
BUG=398257
TBR=asargent
for a trivial rename in ephemeral_app_launcher.cc
Review URL: https://codereview.chromium.org/980353003
Cr-Commit-Position: refs/heads/master@{#321550}
Diffstat (limited to 'extensions/test')
-rw-r--r-- | extensions/test/test_permission_message_provider.cc | 7 | ||||
-rw-r--r-- | extensions/test/test_permission_message_provider.h | 3 |
2 files changed, 0 insertions, 10 deletions
diff --git a/extensions/test/test_permission_message_provider.cc b/extensions/test/test_permission_message_provider.cc index 28a9112..6f7a7d8 100644 --- a/extensions/test/test_permission_message_provider.cc +++ b/extensions/test/test_permission_message_provider.cc @@ -12,13 +12,6 @@ TestPermissionMessageProvider::TestPermissionMessageProvider() { TestPermissionMessageProvider::~TestPermissionMessageProvider() { } -PermissionMessageStrings -TestPermissionMessageProvider::GetPermissionMessageStrings( - const PermissionSet* permissions, - Manifest::Type extension_type) const { - return PermissionMessageStrings(); -} - PermissionMessageIDs TestPermissionMessageProvider::GetLegacyPermissionMessageIDs( const PermissionSet* permissions, diff --git a/extensions/test/test_permission_message_provider.h b/extensions/test/test_permission_message_provider.h index 6cefa22..091fe01 100644 --- a/extensions/test/test_permission_message_provider.h +++ b/extensions/test/test_permission_message_provider.h @@ -16,9 +16,6 @@ class TestPermissionMessageProvider : public PermissionMessageProvider { ~TestPermissionMessageProvider() override; private: - PermissionMessageStrings GetPermissionMessageStrings( - const PermissionSet* permissions, - Manifest::Type extension_type) const override; PermissionMessageIDs GetLegacyPermissionMessageIDs( const PermissionSet* permissions, Manifest::Type extension_type) const override; |