diff options
| author | mtomasz@chromium.org <mtomasz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-23 00:54:16 +0000 |
|---|---|---|
| committer | mtomasz@chromium.org <mtomasz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-23 00:54:16 +0000 |
| commit | 13017122a979d36d0384c141cc89a531cb1ac262 (patch) | |
| tree | da1c4848dcdb41510a80c32f12a4e89ed993d71b /extensions | |
| parent | 54d558482299dd1ab829eea2beb14cc277df8f13 (diff) | |
| download | chromium_src-13017122a979d36d0384c141cc89a531cb1ac262.zip chromium_src-13017122a979d36d0384c141cc89a531cb1ac262.tar.gz chromium_src-13017122a979d36d0384c141cc89a531cb1ac262.tar.bz2 | |
[fsp] [reland] Cleanup handling errors for operation requests.
This is a reland of https://codereview.chromium.org/335753004/, after reverting
because of breaking ASAN bots. Includes a trivial fix. The original description
is below.
This CL removes redundant internal functions which are identical, and replaces
them with one.
Moreover, the new general purpose error API function, passes now the entire
value to the request manager. This is because, very soon, we are going to
pass extra information with every error and success responses and we want to
have access to them in the RequestManager.
TBR=benwells@chromium.org, isherman@chromium.org, kinaba@chromium.org
TEST=unit_tests, browser_tests: *FileSystemProvider*
BUG=373165, 384201
Review URL: https://codereview.chromium.org/342893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279023 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/browser/extension_function_histogram_value.h | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/extensions/browser/extension_function_histogram_value.h b/extensions/browser/extension_function_histogram_value.h index 7d0263a..44beada 100644 --- a/extensions/browser/extension_function_histogram_value.h +++ b/extensions/browser/extension_function_histogram_value.h @@ -776,7 +776,7 @@ enum HistogramValue { DELETED_BLUETOOTH_GET_SOCKETS, FILESYSTEMPROVIDER_UNMOUNT, FILESYSTEMPROVIDERINTERNAL_UNMOUNTREQUESTEDSUCCESS, - FILESYSTEMPROVIDERINTERNAL_UNMOUNTREQUESTEDERROR, + DELETED_FILESYSTEMPROVIDERINTERNAL_UNMOUNTREQUESTEDERROR, MEDIAGALLERIES_DROPPERMISSIONFORMEDIAFILESYSTEM, WEBCAMPRIVATE_SET, WEBCAMPRIVATE_RESET, @@ -809,7 +809,7 @@ enum HistogramValue { WEBSTOREPRIVATE_SIGNINFUNCTION, SHELL_CREATEWINDOW, FILESYSTEMPROVIDERINTERNAL_GETMETADATAREQUESTEDSUCCESS, - FILESYSTEMPROVIDERINTERNAL_GETMETADATAREQUESTEDERROR, + DELETED_FILESYSTEMPROVIDERINTERNAL_GETMETADATAREQUESTEDERROR, BROWSER_OPENTAB, MANAGEMENT_CREATEAPPSHORTCUT, WEBVIEW_SHOWCONTEXTMENU, @@ -819,19 +819,19 @@ enum HistogramValue { HOTWORDPRIVATE_SETHOTWORDSESSIONSTATE, HOTWORDPRIVATE_NOTIFYHOTWORDRECOGNITION, FILESYSTEMPROVIDERINTERNAL_READDIRECTORYREQUESTEDSUCCESS, - FILESYSTEMPROVIDERINTERNAL_READDIRECTORYREQUESTEDERROR, + DELETED_FILESYSTEMPROVIDERINTERNAL_READDIRECTORYREQUESTEDERROR, LEDGER_BATCHEXECUTE, FILESYSTEMPROVIDERINTERNAL_OPENFILEREQUESTEDSUCCESS, - FILESYSTEMPROVIDERINTERNAL_OPENFILEREQUESTEDERROR, + DELETED_FILESYSTEMPROVIDERINTERNAL_OPENFILEREQUESTEDERROR, FILESYSTEMPROVIDERINTERNAL_CLOSEFILEREQUESTEDSUCCESS, - FILESYSTEMPROVIDERINTERNAL_CLOSEFILEREQUESTEDERROR, + DELETED_FILESYSTEMPROVIDERINTERNAL_CLOSEFILEREQUESTEDERROR, SYNCEDNOTIFICATIONSPRIVATE_GETINITIALDATA, SYNCEDNOTIFICATIONSPRIVATE_UPDATENOTIFICATION, SYNCEDNOTIFICATIONSPRIVATE_SETRENDERCONTEXT, IDENTITY_GETACCOUNTS, FILEBROWSERPRIVATE_RESOLVEISOLATEDENTRIES, FILESYSTEMPROVIDERINTERNAL_READFILEREQUESTEDSUCCESS, - FILESYSTEMPROVIDERINTERNAL_READFILEREQUESTEDERROR, + DELETED_FILESYSTEMPROVIDERINTERNAL_READFILEREQUESTEDERROR, NETWORKINGPRIVATE_GETNETWORKS, WEBVIEW_SETNAME, ENTERPRISE_PLATFORMKEYSINTERNAL_GENERATEKEY, @@ -855,6 +855,7 @@ enum HistogramValue { BLUETOOTHLOWENERGY_DISCONNECT, WEBSTOREPRIVATE_GETEPHEMERALAPPSENABLED, WEBSTOREPRIVATE_LAUNCHEPHEMERALAPP, + FILESYSTEMPROVIDERINTERNAL_OPERATIONREQUESTEDERROR, // Last entry: Add new entries above and ensure to update // tools/metrics/histograms/histograms/histograms.xml. ENUM_BOUNDARY |