diff options
| author | rpaquay@chromium.org <rpaquay@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-26 04:06:38 +0000 |
|---|---|---|
| committer | rpaquay@chromium.org <rpaquay@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-26 04:06:38 +0000 |
| commit | f371c89b3a65c1a24a19ff5b69e24425b0a7ed4d (patch) | |
| tree | 4aae7a77520b012eea0a572956c96f5327b33481 /extensions | |
| parent | 76d206cbdd193d21f6c6dbf279c4e9e990021eb5 (diff) | |
| download | chromium_src-f371c89b3a65c1a24a19ff5b69e24425b0a7ed4d.zip chromium_src-f371c89b3a65c1a24a19ff5b69e24425b0a7ed4d.tar.gz chromium_src-f371c89b3a65c1a24a19ff5b69e24425b0a7ed4d.tar.bz2 | |
Add support for top level "sockets" manifest key.
Given the parsing logic for sockets permission string is non trivial, one of the challenges of this CL is to re-use the code from SocketPermissionData.
Note it would have been ideal to re-use the SocketPermission class itself, but i found it to be too tightly coupled with the permission system, and we are implementing a top level manifest key (i.e. we deal with ManifestData structures).
What this CL addresses specifically is the ability for "SocketsUdpXxx" API function to call SocketsApiPermissions::CheckParam for checking permissions.
What this CL doesn't address (yet) is to make sure the "Permissions" UI shows the socket permissions -- i.e. calling SocketPermission::GetMessages(). This proves non-trivial because this code is also tightly coupled to the permission code. I am open to suggestion on how to address this issue.
BUG=275964
Review URL: https://codereview.chromium.org/22935014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225315 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/common/manifest_constants.cc | 1 | ||||
| -rw-r--r-- | extensions/common/manifest_constants.h | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/extensions/common/manifest_constants.cc b/extensions/common/manifest_constants.cc index e9b5938..ec5a878 100644 --- a/extensions/common/manifest_constants.cc +++ b/extensions/common/manifest_constants.cc @@ -112,6 +112,7 @@ const char kShiftKey[] = "shiftKey"; const char kShortcutKey[] = "shortcutKey"; const char kShortName[] = "short_name"; const char kSignature[] = "signature"; +const char kSockets[] = "sockets"; const char kSpellcheck[] = "spellcheck"; const char kSpellcheckDictionaryFormat[] = "dictionary_format"; const char kSpellcheckDictionaryLanguage[] = "dictionary_language"; diff --git a/extensions/common/manifest_constants.h b/extensions/common/manifest_constants.h index 53fb1ef..241387e 100644 --- a/extensions/common/manifest_constants.h +++ b/extensions/common/manifest_constants.h @@ -121,6 +121,7 @@ extern const char kShiftKey[]; extern const char kShortcutKey[]; extern const char kShortName[]; extern const char kSignature[]; +extern const char kSockets[]; extern const char kSpellcheck[]; extern const char kSpellcheckDictionaryFormat[]; extern const char kSpellcheckDictionaryLanguage[]; |