summaryrefslogtreecommitdiffstats
path: root/extensions
diff options
context:
space:
mode:
authorpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-03-18 19:04:21 +0000
committerpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-03-18 19:04:21 +0000
commit03cf96e71f1855f80a4b9214aab7c7fae60ec87c (patch)
treeaf118309b7e143c83f20456858c68b3ac62e0da1 /extensions
parent89d1a8b163dc905efeea6d391f4d02deafccf59c (diff)
downloadchromium_src-03cf96e71f1855f80a4b9214aab7c7fae60ec87c.zip
chromium_src-03cf96e71f1855f80a4b9214aab7c7fae60ec87c.tar.gz
chromium_src-03cf96e71f1855f80a4b9214aab7c7fae60ec87c.tar.bz2
Fix "unreachable code" warnings (MSVC warning 4702), misc. edition.
This CL covers top-level directories that only had one or two modified files. BUG=346399 TEST=none R=darin@chromium.org Review URL: https://codereview.chromium.org/203043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257705 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'extensions')
-rw-r--r--extensions/common/extension_paths.cc32
1 files changed, 12 insertions, 20 deletions
diff --git a/extensions/common/extension_paths.cc b/extensions/common/extension_paths.cc
index 1e0c461..2103100 100644
--- a/extensions/common/extension_paths.cc
+++ b/extensions/common/extension_paths.cc
@@ -10,26 +10,18 @@
namespace extensions {
bool PathProvider(int key, base::FilePath* result) {
- switch (key) {
- case DIR_TEST_DATA: {
- base::FilePath cur;
- if (!PathService::Get(base::DIR_SOURCE_ROOT, &cur))
- return false;
- cur = cur.Append(FILE_PATH_LITERAL("extensions"));
- cur = cur.Append(FILE_PATH_LITERAL("test"));
- cur = cur.Append(FILE_PATH_LITERAL("data"));
- if (!base::PathExists(cur)) // we don't want to create this
- return false;
-
- *result = cur;
- return true;
- break;
- }
- default:
- return false;
- }
-
- return false;
+ if (key != DIR_TEST_DATA)
+ return false;
+ base::FilePath cur;
+ if (!PathService::Get(base::DIR_SOURCE_ROOT, &cur))
+ return false;
+ cur = cur.Append(FILE_PATH_LITERAL("extensions"));
+ cur = cur.Append(FILE_PATH_LITERAL("test"));
+ cur = cur.Append(FILE_PATH_LITERAL("data"));
+ if (!base::PathExists(cur)) // we don't want to create this
+ return false;
+ *result = cur;
+ return true;
}
// This cannot be done as a static initializer sadly since Visual Studio will