summaryrefslogtreecommitdiffstats
path: root/extensions
diff options
context:
space:
mode:
authorrockot <rockot@chromium.org>2014-10-15 14:58:07 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-15 21:58:29 +0000
commitf2a6b62c728822b52356cd3385e41a5a36303ff0 (patch)
treee856d4293f2b604057cb8fe28c983e7a36ddc533 /extensions
parent1bb23605c6717457ec1b48db72e46deb71309c11 (diff)
downloadchromium_src-f2a6b62c728822b52356cd3385e41a5a36303ff0.zip
chromium_src-f2a6b62c728822b52356cd3385e41a5a36303ff0.tar.gz
chromium_src-f2a6b62c728822b52356cd3385e41a5a36303ff0.tar.bz2
Remove //chrome deps from ExtensionDownloader
This frees ExtensionDownloader of any remaining dependencies on //chrome in preparation for its move to //extensions/browser. The move is left for a follow-up CL. BUG=398671 Review URL: https://codereview.chromium.org/651403003 Cr-Commit-Position: refs/heads/master@{#299776}
Diffstat (limited to 'extensions')
-rw-r--r--extensions/browser/extensions_browser_client.h9
-rw-r--r--extensions/browser/test_extensions_browser_client.cc9
-rw-r--r--extensions/browser/test_extensions_browser_client.h3
-rw-r--r--extensions/shell/browser/shell_extensions_browser_client.cc9
-rw-r--r--extensions/shell/browser/shell_extensions_browser_client.h3
5 files changed, 33 insertions, 0 deletions
diff --git a/extensions/browser/extensions_browser_client.h b/extensions/browser/extensions_browser_client.h
index 5b3b1d2..e3ac4a5 100644
--- a/extensions/browser/extensions_browser_client.h
+++ b/extensions/browser/extensions_browser_client.h
@@ -191,6 +191,15 @@ class ExtensionsBrowserClient {
// Gets the single ExtensionCache instance shared across the browser process.
virtual ExtensionCache* GetExtensionCache() = 0;
+ // Indicates whether extension update checks should be allowed.
+ virtual bool IsBackgroundUpdateAllowed() = 0;
+
+ // Indicates whether an extension update which specifies its minimum browser
+ // version as |min_version| can be installed by the client. Not all extensions
+ // embedders share the same versioning model, so interpretation of the string
+ // is left up to the embedder.
+ virtual bool IsMinBrowserVersionSupported(const std::string& min_version) = 0;
+
// Returns the single instance of |this|.
static ExtensionsBrowserClient* Get();
diff --git a/extensions/browser/test_extensions_browser_client.cc b/extensions/browser/test_extensions_browser_client.cc
index 409469b..01be380 100644
--- a/extensions/browser/test_extensions_browser_client.cc
+++ b/extensions/browser/test_extensions_browser_client.cc
@@ -177,4 +177,13 @@ ExtensionCache* TestExtensionsBrowserClient::GetExtensionCache() {
return extension_cache_.get();
}
+bool TestExtensionsBrowserClient::IsBackgroundUpdateAllowed() {
+ return true;
+}
+
+bool TestExtensionsBrowserClient::IsMinBrowserVersionSupported(
+ const std::string& min_version) {
+ return true;
+}
+
} // namespace extensions
diff --git a/extensions/browser/test_extensions_browser_client.h b/extensions/browser/test_extensions_browser_client.h
index 632ed93..3ea76be 100644
--- a/extensions/browser/test_extensions_browser_client.h
+++ b/extensions/browser/test_extensions_browser_client.h
@@ -90,6 +90,9 @@ class TestExtensionsBrowserClient : public ExtensionsBrowserClient {
scoped_ptr<base::ListValue> args) override;
virtual net::NetLog* GetNetLog() override;
virtual ExtensionCache* GetExtensionCache() override;
+ virtual bool IsBackgroundUpdateAllowed() override;
+ virtual bool IsMinBrowserVersionSupported(
+ const std::string& min_version) override;
private:
content::BrowserContext* main_context_; // Not owned.
diff --git a/extensions/shell/browser/shell_extensions_browser_client.cc b/extensions/shell/browser/shell_extensions_browser_client.cc
index 68c3448..b36494e 100644
--- a/extensions/shell/browser/shell_extensions_browser_client.cc
+++ b/extensions/shell/browser/shell_extensions_browser_client.cc
@@ -226,4 +226,13 @@ ExtensionCache* ShellExtensionsBrowserClient::GetExtensionCache() {
return extension_cache_.get();
}
+bool ShellExtensionsBrowserClient::IsBackgroundUpdateAllowed() {
+ return true;
+}
+
+bool ShellExtensionsBrowserClient::IsMinBrowserVersionSupported(
+ const std::string& min_version) {
+ return true;
+}
+
} // namespace extensions
diff --git a/extensions/shell/browser/shell_extensions_browser_client.h b/extensions/shell/browser/shell_extensions_browser_client.h
index 23ede3e..a468c0f 100644
--- a/extensions/shell/browser/shell_extensions_browser_client.h
+++ b/extensions/shell/browser/shell_extensions_browser_client.h
@@ -79,6 +79,9 @@ class ShellExtensionsBrowserClient : public ExtensionsBrowserClient {
scoped_ptr<base::ListValue> args) override;
virtual net::NetLog* GetNetLog() override;
virtual ExtensionCache* GetExtensionCache() override;
+ virtual bool IsBackgroundUpdateAllowed() override;
+ virtual bool IsMinBrowserVersionSupported(
+ const std::string& min_version) override;
private:
// The single BrowserContext for app_shell. Not owned.