summaryrefslogtreecommitdiffstats
path: root/extensions
diff options
context:
space:
mode:
authordbeam <dbeam@chromium.org>2015-05-04 20:22:44 -0700
committerCommit bot <commit-bot@chromium.org>2015-05-05 03:23:17 +0000
commiteec7904ff5ce85c3cf4fead7890c889d418aff14 (patch)
treef5173a9060af9d109ba97ee9a6b38d12d3e2c8ed /extensions
parent86b2cb8e894ddf292e83b5bd1d03e9cc93d18b3f (diff)
downloadchromium_src-eec7904ff5ce85c3cf4fead7890c889d418aff14.zip
chromium_src-eec7904ff5ce85c3cf4fead7890c889d418aff14.tar.gz
chromium_src-eec7904ff5ce85c3cf4fead7890c889d418aff14.tar.bz2
Revert of Change the callsites of InterfacePtr<> methods which directly deal with message pipe handles. (patchset #3 id:40001 of https://codereview.chromium.org/1120753004/)
Reason for revert: This might've broke Mac 10.9's IPC message handling(?): https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/5606 Lots of errors like this: [361:34051:0504/184612:WARNING:ipc_mojo_bootstrap.cc(214)] Detected error on Mojo bootstrap channel. [361:34051:0504/184612:WARNING:ipc_message_attachment_set.cc(37)] MessageAttachmentSet destroyed with unconsumed descriptors: 0/1 Original issue's description: > Change the callsites of InterfacePtr<> methods which directly deal with message pipe handles. > > Because those methods are going to be removed. > > BUG=None > > Committed: https://crrev.com/99f65895acf2086af0755b9ea865d6ded4baecd6 > Cr-Commit-Position: refs/heads/master@{#328232} TBR=jam@chromium.org,rockot@chromium.org,yzshen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review URL: https://codereview.chromium.org/1124553004 Cr-Commit-Position: refs/heads/master@{#328264}
Diffstat (limited to 'extensions')
-rw-r--r--extensions/renderer/api/serial/data_receiver_unittest.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/extensions/renderer/api/serial/data_receiver_unittest.cc b/extensions/renderer/api/serial/data_receiver_unittest.cc
index 623fcbf..1be15969 100644
--- a/extensions/renderer/api/serial/data_receiver_unittest.cc
+++ b/extensions/renderer/api/serial/data_receiver_unittest.cc
@@ -38,7 +38,7 @@ class DataReceiverFactory : public gin::Wrappable<DataReceiverFactory> {
callback_.Run(mojo::GetProxy(&sink), client.Pass());
gin::Dictionary result = gin::Dictionary::CreateEmpty(isolate_);
- result.Set("source", sink.PassInterface().PassHandle().release());
+ result.Set("source", sink.PassMessagePipe().release());
result.Set("client", client_request.PassMessagePipe().release());
return result;
}