diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-30 20:06:30 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-30 20:06:30 +0000 |
commit | 20f0487a5b73e8071af2612150301b0942cbf0e2 (patch) | |
tree | ecee69b28f16712bdc1558ac0a015ac80095c761 /gfx | |
parent | 167b0dd17d5ed57ff293b6480ccaed706e0bc9cb (diff) | |
download | chromium_src-20f0487a5b73e8071af2612150301b0942cbf0e2.zip chromium_src-20f0487a5b73e8071af2612150301b0942cbf0e2.tar.gz chromium_src-20f0487a5b73e8071af2612150301b0942cbf0e2.tar.bz2 |
FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs.
Cuts ~2MB off our .a files (Debug, Linux). Also added the "virtual" keyword on
a whole bunch of virtual dtors that were missing it.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3522004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61100 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gfx')
-rw-r--r-- | gfx/gtk_native_view_id_manager.cc | 3 | ||||
-rw-r--r-- | gfx/gtk_native_view_id_manager.h | 1 | ||||
-rw-r--r-- | gfx/platform_font_gtk.cc | 2 | ||||
-rw-r--r-- | gfx/platform_font_gtk.h | 2 |
4 files changed, 7 insertions, 1 deletions
diff --git a/gfx/gtk_native_view_id_manager.cc b/gfx/gtk_native_view_id_manager.cc index 91407283a..0cb96df 100644 --- a/gfx/gtk_native_view_id_manager.cc +++ b/gfx/gtk_native_view_id_manager.cc @@ -38,6 +38,9 @@ static void OnDestroy(GtkObject* obj, void* arg) { GtkNativeViewManager::GtkNativeViewManager() { } +GtkNativeViewManager::~GtkNativeViewManager() { +} + gfx::NativeViewId GtkNativeViewManager::GetIdForWidget(gfx::NativeView widget) { // This is just for unit tests: if (!widget) diff --git a/gfx/gtk_native_view_id_manager.h b/gfx/gtk_native_view_id_manager.h index b53d494..0a90e2f 100644 --- a/gfx/gtk_native_view_id_manager.h +++ b/gfx/gtk_native_view_id_manager.h @@ -69,6 +69,7 @@ class GtkNativeViewManager { private: // This object is a singleton: GtkNativeViewManager(); + ~GtkNativeViewManager(); friend struct DefaultSingletonTraits<GtkNativeViewManager>; struct NativeViewInfo { diff --git a/gfx/platform_font_gtk.cc b/gfx/platform_font_gtk.cc index 6458a48..5ed7793 100644 --- a/gfx/platform_font_gtk.cc +++ b/gfx/platform_font_gtk.cc @@ -279,6 +279,8 @@ PlatformFontGtk::PlatformFontGtk(SkTypeface* typeface, InitWithTypefaceNameSizeAndStyle(typeface, name, size, style); } +PlatformFontGtk::~PlatformFontGtk() {} + void PlatformFontGtk::InitWithNameAndSize(const std::wstring& font_name, int font_size) { DCHECK_GT(font_size, 0); diff --git a/gfx/platform_font_gtk.h b/gfx/platform_font_gtk.h index 3c507fb..bd26d8f 100644 --- a/gfx/platform_font_gtk.h +++ b/gfx/platform_font_gtk.h @@ -53,7 +53,7 @@ class PlatformFontGtk : public PlatformFont { const std::wstring& name, int size, int style); - virtual ~PlatformFontGtk() {} + virtual ~PlatformFontGtk(); // Initialize this object. void InitWithNameAndSize(const std::wstring& font_name, int font_size); |