diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-28 15:26:49 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-28 15:26:49 +0000 |
| commit | f2eec2ece4d15d682bae05faf4fb3c24db1c8972 (patch) | |
| tree | da790c65c981a05ac675e7a32f29d60e2be97094 /gin/context_holder.cc | |
| parent | 6d095a8b8d4fef7121eca28736b61d115eaca24f (diff) | |
| download | chromium_src-f2eec2ece4d15d682bae05faf4fb3c24db1c8972.zip chromium_src-f2eec2ece4d15d682bae05faf4fb3c24db1c8972.tar.gz chromium_src-f2eec2ece4d15d682bae05faf4fb3c24db1c8972.tar.bz2 | |
Nukes ContextSupplement and makes PerContextData extend SupportUserData
This gives the same functionality and ownership model while making it
simpler to associate arbitrary data with a context.
BUG=none
TEST=none
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/183433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254126 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gin/context_holder.cc')
| -rw-r--r-- | gin/context_holder.cc | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/gin/context_holder.cc b/gin/context_holder.cc index fba2a2a..4a7be7c 100644 --- a/gin/context_holder.cc +++ b/gin/context_holder.cc @@ -14,10 +14,7 @@ ContextHolder::ContextHolder(v8::Isolate* isolate) } ContextHolder::~ContextHolder() { - v8::HandleScope handle_scope(isolate()); - v8::Handle<v8::Context> context = this->context(); - - data_->Detach(context); + // PerContextData needs to be destroyed before the context. data_.reset(); } |