summaryrefslogtreecommitdiffstats
path: root/gin/dictionary.cc
diff options
context:
space:
mode:
authorabarth@chromium.org <abarth@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-11-21 18:38:51 +0000
committerabarth@chromium.org <abarth@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-11-21 18:38:51 +0000
commit93f9f360fc88ea3bae8e74b7b22ad25d1ddaec85 (patch)
tree35d4b253f7d95749f54c3ed179bb8c99834a3f79 /gin/dictionary.cc
parent69ef3fe6c0e79036f8e6f1b740b0cd96137e461e (diff)
downloadchromium_src-93f9f360fc88ea3bae8e74b7b22ad25d1ddaec85.zip
chromium_src-93f9f360fc88ea3bae8e74b7b22ad25d1ddaec85.tar.gz
chromium_src-93f9f360fc88ea3bae8e74b7b22ad25d1ddaec85.tar.bz2
[Gin] Add a mechanism for wrapping C++ object
This CL adds a mechanism for wrapping C++ objects to Gin. The approach in this CL is similar to Blink's ScriptWrappable class, with a couple of differences: 1) gin::Wrappable has a vtable whereas Blink's ScriptWrappable class does not. Having a vtable in this base class lets us simplify a large number of concerns. We've talked about adding a vtable to ScriptWrappable but have avoided it because Blink creates many thousands of wrapped objects. When we refactor Blink to use Gin, we can still support the non-vtable approach, but most clients of Gin will want the simpler approach. 2) In Gin, we've bound together the notion of being reference counted with the notion of being wrappable from JavaScript. In Blink, those concepts are separate because we don't want to introduce a virtual destructor for ScriptWrappable. However, because gin::Wrappable already has a vtable, adding a virtual destructor is relatively cheap. Actually wrapping a C++ object still takes too much typing, but we can improve that in future CLs. R=jochen@chromium.org BUG=317398 Review URL: https://codereview.chromium.org/79203004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236555 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gin/dictionary.cc')
-rw-r--r--gin/dictionary.cc3
1 files changed, 2 insertions, 1 deletions
diff --git a/gin/dictionary.cc b/gin/dictionary.cc
index 0da85af..ca6227e 100644
--- a/gin/dictionary.cc
+++ b/gin/dictionary.cc
@@ -30,7 +30,8 @@ v8::Handle<v8::Value> Converter<Dictionary>::ToV8(v8::Isolate* isolate,
return val.object_;
}
-bool FromV8(v8::Handle<v8::Value> val, Dictionary* out) {
+bool Converter<Dictionary>::FromV8(v8::Handle<v8::Value> val,
+ Dictionary* out) {
if (!val->IsObject())
return false;
*out = Dictionary(out->isolate(), v8::Handle<v8::Object>::Cast(val));