diff options
| author | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-27 03:38:26 +0000 |
|---|---|---|
| committer | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-27 03:38:26 +0000 |
| commit | 7618ebbb8685c7bb6d1477791c524d667cae2f70 (patch) | |
| tree | 4ae52faf34f9b2afd83cb81ceb6ef60a3db66e93 /gin/dictionary.h | |
| parent | 2ff0a25baaf6a542fadd4cfd32589476b8eba3b0 (diff) | |
| download | chromium_src-7618ebbb8685c7bb6d1477791c524d667cae2f70.zip chromium_src-7618ebbb8685c7bb6d1477791c524d667cae2f70.tar.gz chromium_src-7618ebbb8685c7bb6d1477791c524d667cae2f70.tar.bz2 | |
Convert the rest of the functions in core.cc to use CreateFunctionTemplate.
BUG=
Review URL: https://codereview.chromium.org/89723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237492 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gin/dictionary.h')
| -rw-r--r-- | gin/dictionary.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/gin/dictionary.h b/gin/dictionary.h index a6b450b..bc55087 100644 --- a/gin/dictionary.h +++ b/gin/dictionary.h @@ -32,7 +32,7 @@ class Dictionary { template<typename T> bool Get(const std::string& key, T* out) { v8::Handle<v8::Value> val = object_->Get(StringToV8(isolate_, key)); - return ConvertFromV8(val, out); + return ConvertFromV8(isolate_, val, out); } template<typename T> @@ -45,6 +45,7 @@ class Dictionary { private: friend struct Converter<Dictionary>; + // TODO(aa): Remove this. Instead, get via FromV8(), Set(), and Get(). v8::Isolate* isolate_; v8::Handle<v8::Object> object_; }; @@ -53,7 +54,8 @@ template<> struct Converter<Dictionary> { static v8::Handle<v8::Value> ToV8(v8::Isolate* isolate, Dictionary val); - static bool FromV8(v8::Handle<v8::Value> val, + static bool FromV8(v8::Isolate* isolate, + v8::Handle<v8::Value> val, Dictionary* out); }; |