diff options
| author | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-03 15:13:49 +0000 |
|---|---|---|
| committer | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-03 15:13:49 +0000 |
| commit | add8fb170d60541013763ed931eb55f5655d6e73 (patch) | |
| tree | 336e6fb61155a2f0934de49e35ce4ac25bc59a50 /gin | |
| parent | 94686e41269a314561b71d6dfd79ffcca5dee628 (diff) | |
| download | chromium_src-add8fb170d60541013763ed931eb55f5655d6e73.zip chromium_src-add8fb170d60541013763ed931eb55f5655d6e73.tar.gz chromium_src-add8fb170d60541013763ed931eb55f5655d6e73.tar.bz2 | |
Remove usage of deprecate v8::Number constructors from gin
TBR=dcarney@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/109563003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242884 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gin')
| -rw-r--r-- | gin/converter_unittest.cc | 5 | ||||
| -rw-r--r-- | gin/wrappable_unittest.cc | 2 |
2 files changed, 4 insertions, 3 deletions
diff --git a/gin/converter_unittest.cc b/gin/converter_unittest.cc index 9b831b9..791d7e6 100644 --- a/gin/converter_unittest.cc +++ b/gin/converter_unittest.cc @@ -73,8 +73,9 @@ TEST_F(ConverterTest, Int32) { int test_data_to[] = {-1, 0, 1}; for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data_to); ++i) { - EXPECT_TRUE(Converter<int32_t>::ToV8(instance_->isolate(), - test_data_to[i])->StrictEquals(Integer::New(test_data_to[i]))); + EXPECT_TRUE(Converter<int32_t>::ToV8(instance_->isolate(), test_data_to[i]) + ->StrictEquals( + Integer::New(instance_->isolate(), test_data_to[i]))); } struct { diff --git a/gin/wrappable_unittest.cc b/gin/wrappable_unittest.cc index 2428dc1..09fef24 100644 --- a/gin/wrappable_unittest.cc +++ b/gin/wrappable_unittest.cc @@ -114,7 +114,7 @@ TEST_F(WrappableTest, UnwrapFailures) { v8::HandleScope handle_scope(isolate); // Something that isn't an object. - v8::Handle<v8::Value> thing = v8::Number::New(42); + v8::Handle<v8::Value> thing = v8::Number::New(isolate, 42); MyObject* unwrapped = NULL; EXPECT_FALSE(ConvertFromV8(isolate, thing, &unwrapped)); EXPECT_FALSE(unwrapped); |