diff options
| author | asargent@chromium.org <asargent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-16 22:00:33 +0000 |
|---|---|---|
| committer | asargent@chromium.org <asargent@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-16 22:00:33 +0000 |
| commit | f76dc353b84dcdd78de944db874424c4f4b14b95 (patch) | |
| tree | 30d67f9a83be589667eb823d016a4d3bde38a586 /google_apis/gcm/gcm_client.cc | |
| parent | bf19bf1cef011d6fa34f8ae393c149d5f2114052 (diff) | |
| download | chromium_src-f76dc353b84dcdd78de944db874424c4f4b14b95.zip chromium_src-f76dc353b84dcdd78de944db874424c4f4b14b95.tar.gz chromium_src-f76dc353b84dcdd78de944db874424c4f4b14b95.tar.bz2 | |
Revert 264313 "Add activity recording capability to gcm internal..."
This caused a compile error on the Win x64 builder:
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/17353/steps/compile/logs/stdio
FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\google_apis\gcm\tools\mcs_probe.mcs_probe.obj.rsp /c ..\..\google_apis\gcm\tools\mcs_probe.cc /Foobj\google_apis\gcm\tools\mcs_probe.mcs_probe.obj /Fdobj\google_apis\gcm\mcs_probe.cc.pdb
c:\b\build\slave\cr-win-rel-x64\build\src\google_apis\gcm\tools\mcs_probe.cc(309) :error C2661: 'gcm::MCSClient::MCSClient' : no overloaded function takes 4 arguments
ninja: build stopped: subcommand failed.
> Add activity recording capability to gcm internals page. User can refresh, start/stop recording, and clear recording logs.
> Also added more information to the device info section and fixed a bug there.
>
> arv: owner review of chrome/browser/resources/*.
> jianli & fgorski please review the rest of the code, and zea for owner review of these code.
>
> BUG=341256
>
> Review URL: https://codereview.chromium.org/202083005
TBR=juyik@chromium.org
Review URL: https://codereview.chromium.org/240583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264319 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'google_apis/gcm/gcm_client.cc')
| -rw-r--r-- | google_apis/gcm/gcm_client.cc | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/google_apis/gcm/gcm_client.cc b/google_apis/gcm/gcm_client.cc index 75884d6..3bdd699 100644 --- a/google_apis/gcm/gcm_client.cc +++ b/google_apis/gcm/gcm_client.cc @@ -24,12 +24,7 @@ GCMClient::SendErrorDetails::SendErrorDetails() : result(UNKNOWN_ERROR) {} GCMClient::SendErrorDetails::~SendErrorDetails() {} GCMClient::GCMStatistics::GCMStatistics() - : is_recording(false), - gcm_client_created(false), - connection_client_created(false), - android_id(0), - send_queue_size(0), - resend_queue_size(0) { + : gcm_client_created(false), connection_client_created(false) { } GCMClient::GCMStatistics::~GCMStatistics() { |