summaryrefslogtreecommitdiffstats
path: root/google_update
diff options
context:
space:
mode:
authorananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-28 02:41:56 +0000
committerananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-28 02:41:56 +0000
commit54422f4bf16c6d15b9cbf760ff006fbc57c0df7e (patch)
tree50b97c552ad2994ad4902cffe2dbeaeee1938022 /google_update
parent616f9cd2cd3e43d95c8d90fe01dc4241b2a5b08c (diff)
downloadchromium_src-54422f4bf16c6d15b9cbf760ff006fbc57c0df7e.zip
chromium_src-54422f4bf16c6d15b9cbf760ff006fbc57c0df7e.tar.gz
chromium_src-54422f4bf16c6d15b9cbf760ff006fbc57c0df7e.tar.bz2
It looks like the Chrome NPAPI plugin installer has been broken since we first updated chrome webkit after 1.0 shipped.
Basically in the 1.0 branch when the plugin was instantiated in its instantiation it would get the mime type along with the list of other arguments. If an object tag was specified with the classid, it would get mapped to the mime type. With the webkit merge the classs id is passed in along with the mime type. The plugin installer thinks that this is an activex installation on receiving a valid class id and and ends up checking if it is a white listed classid, etc. All this code will be taken out along with the activex shim in the near future. For now we take this code path only if we don't have a valid mime type. This fixes http://code.google.com/p/chromium/issues/detail?id=8584 Added a plugin test for the argument parsing functionality in the default plugin. I changed the ParseInstantiationArguments function in the plugin installer to a static function to be able to unit test this. Bug=8584 Review URL: http://codereview.chromium.org/42684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12733 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'google_update')
0 files changed, 0 insertions, 0 deletions