diff options
| author | zmo@google.com <zmo@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-24 20:42:53 +0000 |
|---|---|---|
| committer | zmo@google.com <zmo@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-24 20:42:53 +0000 |
| commit | c5d79834e2053a5e4983198255c8f58b5ba596cb (patch) | |
| tree | 224e16ab6e2fc7fcf908ba898b42000b964200dd /gpu/command_buffer/build_gles2_cmd_buffer.py | |
| parent | 49420ffb6ce5a31ed48d1212bd0db878c2c6b7d2 (diff) | |
| download | chromium_src-c5d79834e2053a5e4983198255c8f58b5ba596cb.zip chromium_src-c5d79834e2053a5e4983198255c8f58b5ba596cb.tar.gz chromium_src-c5d79834e2053a5e4983198255c8f58b5ba596cb.tar.bz2 | |
Fix WebGL getParameter bug in command buffer.
GetHelper was truning all getParameter return values into integers, even
if they should have been floats. By returning false in GetHelper, it
lets the individual DoGet(Float,Boolean,Integer)v functions skip this
behavior and return the real value directly.
Also, update unit tests now that the correct function is being called.
BUG=51331
TEST=LayoutTests/fast/canvas/webgl/gl-get-calls.html
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60515 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gpu/command_buffer/build_gles2_cmd_buffer.py')
| -rwxr-xr-x | gpu/command_buffer/build_gles2_cmd_buffer.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py index 1209549..08b1bab 100755 --- a/gpu/command_buffer/build_gles2_cmd_buffer.py +++ b/gpu/command_buffer/build_gles2_cmd_buffer.py @@ -1233,7 +1233,7 @@ _FUNCTION_INFO = { 'type': 'GETn', 'result': ['SizedResult<GLboolean>'], 'decoder_func': 'DoGetBooleanv', - 'gl_test_func': 'glGetIntegerv', + 'gl_test_func': 'glGetBooleanv', }, 'GetBufferParameteriv': {'type': 'GETn', 'result': ['SizedResult<GLint>']}, 'GetError': { @@ -1246,7 +1246,7 @@ _FUNCTION_INFO = { 'type': 'GETn', 'result': ['SizedResult<GLfloat>'], 'decoder_func': 'DoGetFloatv', - 'gl_test_func': 'glGetIntegerv', + 'gl_test_func': 'glGetFloatv', }, 'GetFramebufferAttachmentParameteriv': { 'type': 'GETn', |