diff options
| author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-08 22:52:11 +0000 |
|---|---|---|
| committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-08 22:52:11 +0000 |
| commit | 3fb28bac3a97af687de76d830d42fe974422f910 (patch) | |
| tree | e4a6478dc1ec65b602502d132b0007349cd6e8fe /gpu/command_buffer/common/cmd_buffer_common.cc | |
| parent | a06f17ed5850efe432327e13ad69a03af7460621 (diff) | |
| download | chromium_src-3fb28bac3a97af687de76d830d42fe974422f910.zip chromium_src-3fb28bac3a97af687de76d830d42fe974422f910.tar.gz chromium_src-3fb28bac3a97af687de76d830d42fe974422f910.tar.bz2 | |
Fix a crash due to CHECK() hit in SafeBrowsingResourceHandler.
The problem was the CHECK() doesn't apply when the resource request has been cancelled via the interstitial page -- if you close the tab displaying the warning, the request is cancelled leading to OnResponseCompleted() firing with an error status, so state_ == STATE_DISPLAYING_BLOCKING_PAGE.
Also made sure this code path handles cancellation of any outstanding url check.
BUG=37674
TEST=Open a URL that causes the safe browsing warning page to be display. Now close the tab containing the warning; should not crash.
Review URL: http://codereview.chromium.org/671009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40955 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gpu/command_buffer/common/cmd_buffer_common.cc')
0 files changed, 0 insertions, 0 deletions