diff options
| author | apatrick@chromium.org <apatrick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-08 18:31:08 +0000 |
|---|---|---|
| committer | apatrick@chromium.org <apatrick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-08 18:31:08 +0000 |
| commit | 20407e957e31a0faf159403d47dc5d1d6c903f9e (patch) | |
| tree | 350962b37d2cb6d9e0fdae78a24efb2bd3c72723 /gpu/command_buffer/common/cmd_buffer_common.cc | |
| parent | 9283f2789927383ece6aedbd948a645164c35c53 (diff) | |
| download | chromium_src-20407e957e31a0faf159403d47dc5d1d6c903f9e.zip chromium_src-20407e957e31a0faf159403d47dc5d1d6c903f9e.tar.gz chromium_src-20407e957e31a0faf159403d47dc5d1d6c903f9e.tar.bz2 | |
Removed dependencies on base from GPU common and client code.
The main change was to make scoped_ptr and the basic types the same for both NaCl and trusted plugins and to implement new logging code for GPU common and client code. Service code and unit tests can still use the logging code in base.
I am really not happy with the new logging code but I thought I'd let you take a look at it to see what you think. The biggest thing I don't like is it uses assert(false) to throw an exception in a platform independent way, which brings up a modal dialog. Not ideal in the middle of a unit test run. I don't know if that will make the bots hang. Hopefully they'll time out or something.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/2936009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58857 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gpu/command_buffer/common/cmd_buffer_common.cc')
| -rw-r--r-- | gpu/command_buffer/common/cmd_buffer_common.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gpu/command_buffer/common/cmd_buffer_common.cc b/gpu/command_buffer/common/cmd_buffer_common.cc index 974bed9..abfdc93 100644 --- a/gpu/command_buffer/common/cmd_buffer_common.cc +++ b/gpu/command_buffer/common/cmd_buffer_common.cc @@ -8,7 +8,7 @@ #include "../common/cmd_buffer_common.h" namespace gpu { -#if !defined(OS_WIN) +#if !defined(_WIN32) // gcc needs this to link, but MSVC requires it not be present const int32 CommandHeader::kMaxSize; #endif |