diff options
| author | zmo@chromium.org <zmo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-06 17:48:26 +0000 |
|---|---|---|
| committer | zmo@chromium.org <zmo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-06 17:48:26 +0000 |
| commit | a8fb8f44bc56943c45bd06034fc004e22ef5da85 (patch) | |
| tree | 0cf04d8183f36b63d56b3704176ea2d53b42f023 /gpu/command_buffer/service/feature_info_unittest.cc | |
| parent | b375601e95723c66b63b567c80dfc69544c91c43 (diff) | |
| download | chromium_src-a8fb8f44bc56943c45bd06034fc004e22ef5da85.zip chromium_src-a8fb8f44bc56943c45bd06034fc004e22ef5da85.tar.gz chromium_src-a8fb8f44bc56943c45bd06034fc004e22ef5da85.tar.bz2 | |
Revert 186416
> Use client side arrays for GL_STREAM_DRAW attributes
>
> Certain GPU/drivers are slow when using constantly changing
> vertex buffers. They also run out of memory as the pipeline
> the buffers so while a buffer is in used being drawn to they
> can't delete it immediately when you upload new data to the
> buffer.
>
> This is an attempt to work around that issue seemlessly by
> using client side arrays for buffers marked as GL_STREAM_DRAW
>
> BUG=178093
>
>
> Review URL: https://chromiumcodereview.appspot.com/12494005
TBR=gman@chromium.org
Review URL: https://codereview.chromium.org/12544006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186459 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gpu/command_buffer/service/feature_info_unittest.cc')
| -rw-r--r-- | gpu/command_buffer/service/feature_info_unittest.cc | 31 |
1 files changed, 0 insertions, 31 deletions
diff --git a/gpu/command_buffer/service/feature_info_unittest.cc b/gpu/command_buffer/service/feature_info_unittest.cc index bf716ff..0edaa78 100644 --- a/gpu/command_buffer/service/feature_info_unittest.cc +++ b/gpu/command_buffer/service/feature_info_unittest.cc @@ -95,7 +95,6 @@ TEST_F(FeatureInfoTest, Basic) { EXPECT_FALSE(info_->workarounds().clear_alpha_in_readpixels); EXPECT_EQ(0, info_->workarounds().max_texture_size); EXPECT_EQ(0, info_->workarounds().max_cube_map_texture_size); - EXPECT_FALSE(info_->workarounds().use_client_side_arrays_for_stream_buffers); // Test good types. { @@ -800,35 +799,5 @@ TEST_F(FeatureInfoTest, InitializeOES_element_index_uint) { EXPECT_TRUE(info_->validators()->index_type.IsValid(GL_UNSIGNED_INT)); } -TEST_F(FeatureInfoTest, InitializeARM) { - SetupInitExpectationsWithVendor("", "ARM", "MAli-T604"); - info_->Initialize(NULL); - EXPECT_TRUE(info_->workarounds().use_client_side_arrays_for_stream_buffers); -} - -TEST_F(FeatureInfoTest, InitializeImagination) { - SetupInitExpectationsWithVendor( - "", "Imagination Techologies", "PowerVR SGX 540"); - info_->Initialize(NULL); - EXPECT_TRUE(info_->workarounds().use_client_side_arrays_for_stream_buffers); - EXPECT_FALSE(info_->feature_flags().native_vertex_array_object); -} - -TEST_F(FeatureInfoTest, InitializeARMVAOs) { - SetupInitExpectationsWithVendor( - "GL_OES_vertex_array_object", "ARM", "MAli-T604"); - info_->Initialize(NULL); - EXPECT_TRUE(info_->workarounds().use_client_side_arrays_for_stream_buffers); - EXPECT_FALSE(info_->feature_flags().native_vertex_array_object); -} - -TEST_F(FeatureInfoTest, InitializeImaginationVAOs) { - SetupInitExpectationsWithVendor( - "GL_OES_vertex_array_object", - "Imagination Techologies", "PowerVR SGX 540"); - info_->Initialize(NULL); - EXPECT_TRUE(info_->workarounds().use_client_side_arrays_for_stream_buffers); -} - } // namespace gles2 } // namespace gpu |