diff options
author | gman@chromium.org <gman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-12 04:51:22 +0000 |
---|---|---|
committer | gman@chromium.org <gman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-12 04:51:22 +0000 |
commit | d42398570e13c364a7f403fc9685ddb437b194f4 (patch) | |
tree | 739c99463efc13bec23138869d3baf9a4d3cc0de /gpu/command_buffer/service | |
parent | e505713377b0ec2e061933ab181854062cb16ffc (diff) | |
download | chromium_src-d42398570e13c364a7f403fc9685ddb437b194f4.zip chromium_src-d42398570e13c364a7f403fc9685ddb437b194f4.tar.gz chromium_src-d42398570e13c364a7f403fc9685ddb437b194f4.tar.bz2 |
Rename and document glCommandBufferEnableCHROMIUM
moved to gl2ext.h. Got rid of gles2_command_buffer.h
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7623001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96507 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gpu/command_buffer/service')
13 files changed, 9 insertions, 21 deletions
diff --git a/gpu/command_buffer/service/context_group.cc b/gpu/command_buffer/service/context_group.cc index f852835..36c8d03 100644 --- a/gpu/command_buffer/service/context_group.cc +++ b/gpu/command_buffer/service/context_group.cc @@ -11,7 +11,6 @@ #include "gpu/command_buffer/service/renderbuffer_manager.h" #include "gpu/command_buffer/service/shader_manager.h" #include "gpu/command_buffer/service/texture_manager.h" -#include "gpu/GLES2/gles2_command_buffer.h" #include "ui/gfx/gl/gl_implementation.h" namespace gpu { diff --git a/gpu/command_buffer/service/context_group_unittest.cc b/gpu/command_buffer/service/context_group_unittest.cc index ed6686b..a651854 100644 --- a/gpu/command_buffer/service/context_group_unittest.cc +++ b/gpu/command_buffer/service/context_group_unittest.cc @@ -8,7 +8,6 @@ #include "gpu/command_buffer/common/gl_mock.h" #include "gpu/command_buffer/service/test_helper.h" #include "gpu/command_buffer/service/texture_manager.h" -#include "gpu/GLES2/gles2_command_buffer.h" #include "testing/gtest/include/gtest/gtest.h" using ::gfx::MockGLInterface; diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc index b9e0d36..4936e7a 100644 --- a/gpu/command_buffer/service/feature_info.cc +++ b/gpu/command_buffer/service/feature_info.cc @@ -6,7 +6,6 @@ #include <string> #include "gpu/command_buffer/service/feature_info.h" #include "gpu/command_buffer/service/gl_utils.h" -#include "gpu/GLES2/gles2_command_buffer.h" #include "ui/gfx/gl/gl_implementation.h" namespace gpu { diff --git a/gpu/command_buffer/service/feature_info_unittest.cc b/gpu/command_buffer/service/feature_info_unittest.cc index d9cd34e..5f87e92 100644 --- a/gpu/command_buffer/service/feature_info_unittest.cc +++ b/gpu/command_buffer/service/feature_info_unittest.cc @@ -8,7 +8,6 @@ #include "gpu/command_buffer/common/gl_mock.h" #include "gpu/command_buffer/service/test_helper.h" #include "gpu/command_buffer/service/texture_manager.h" -#include "gpu/GLES2/gles2_command_buffer.h" #include "testing/gtest/include/gtest/gtest.h" using ::gfx::MockGLInterface; diff --git a/gpu/command_buffer/service/gl_utils.h b/gpu/command_buffer/service/gl_utils.h index 3648d4f..abc9ff2 100644 --- a/gpu/command_buffer/service/gl_utils.h +++ b/gpu/command_buffer/service/gl_utils.h @@ -31,6 +31,7 @@ #define GL_FRAGMENT_SHADER_DERIVATIVE_HINT_OES 0x8B8B #define GL_RGB8_OES 0x8051 #define GL_RGBA8_OES 0x8058 +#define GL_HALF_FLOAT_OES 0x8D61 // GL_OES_EGL_image_external #define GL_TEXTURE_EXTERNAL_OES 0x8D65 diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc index 20e2b11..7a04a7c 100644 --- a/gpu/command_buffer/service/gles2_cmd_decoder.cc +++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc @@ -37,7 +37,6 @@ #include "gpu/command_buffer/service/surface_manager.h" #include "gpu/command_buffer/service/texture_manager.h" #include "gpu/command_buffer/service/vertex_attrib_manager.h" -#include "gpu/GLES2/gles2_command_buffer.h" #include "ui/gfx/gl/gl_context.h" #include "ui/gfx/gl/gl_implementation.h" #include "ui/gfx/gl/gl_surface.h" @@ -6584,10 +6583,10 @@ error::Error GLES2DecoderImpl::HandleSwapBuffers( return error::kNoError; } -error::Error GLES2DecoderImpl::HandleCommandBufferEnableCHROMIUM( - uint32 immediate_data_size, const gles2::CommandBufferEnableCHROMIUM& c) { +error::Error GLES2DecoderImpl::HandleEnableFeatureCHROMIUM( + uint32 immediate_data_size, const gles2::EnableFeatureCHROMIUM& c) { Bucket* bucket = GetBucket(c.bucket_id); - typedef gles2::CommandBufferEnableCHROMIUM::Result Result; + typedef gles2::EnableFeatureCHROMIUM::Result Result; Result* result = GetSharedMemoryAs<Result*>( c.result_shm_id, c.result_shm_offset, sizeof(*result)); if (!result) { @@ -6603,9 +6602,9 @@ error::Error GLES2DecoderImpl::HandleCommandBufferEnableCHROMIUM( } // TODO(gman): make this some kind of table to function pointer thingy. - if (feature_str.compare(PEPPER3D_ALLOW_BUFFERS_ON_MULTIPLE_TARGETS) == 0) { + if (feature_str.compare("pepper3d_allow_buffers_on_multiple_targets") == 0) { buffer_manager()->set_allow_buffers_on_multiple_targets(true); - } else if (feature_str.compare(PEPPER3D_SUPPORT_FIXED_ATTRIBS) == 0) { + } else if (feature_str.compare("pepper3d_support_fixed_attribs") == 0) { buffer_manager()->set_allow_buffers_on_multiple_targets(true); // TODO(gman): decide how to remove the need for this const_cast. // I could make validators_ non const but that seems bad as this is the only @@ -6617,8 +6616,6 @@ error::Error GLES2DecoderImpl::HandleCommandBufferEnableCHROMIUM( // needs to be done it seems like refactoring for one to one of those // methods is a very low priority. const_cast<Validators*>(validators_)->vertex_attrib_type.AddValue(GL_FIXED); - } else if (feature_str.compare(PEPPER3D_SKIP_GLSL_TRANSLATION) == 0) { - use_shader_translator_ = false; } else { return error::kNoError; } diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h index ff07f42..1206925 100644 --- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h +++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h @@ -1704,7 +1704,7 @@ TEST_F(GLES2DecoderTest2, ViewportInvalidArgs3_0) { // TODO(gman): RegisterSharedIdsCHROMIUM -// TODO(gman): CommandBufferEnableCHROMIUM +// TODO(gman): EnableFeatureCHROMIUM // TODO(gman): ResizeCHROMIUM // TODO(gman): GetRequestableExtensionsCHROMIUM diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h index b7379a4..22d341a 100644 --- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h +++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h @@ -18,7 +18,6 @@ #include "gpu/command_buffer/service/shader_manager.h" #include "gpu/command_buffer/service/surface_manager_mock.h" #include "gpu/command_buffer/service/texture_manager.h" -#include "gpu/GLES2/gles2_command_buffer.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/gfx/gl/gl_context_stub.h" #include "ui/gfx/gl/gl_surface_stub.h" diff --git a/gpu/command_buffer/service/test_helper.cc b/gpu/command_buffer/service/test_helper.cc index 2eff474..e441d6a 100644 --- a/gpu/command_buffer/service/test_helper.cc +++ b/gpu/command_buffer/service/test_helper.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -8,7 +8,6 @@ #include "gpu/command_buffer/common/gl_mock.h" #include "gpu/command_buffer/common/types.h" #include "gpu/command_buffer/service/gl_utils.h" -#include "gpu/GLES2/gles2_command_buffer.h" #include "testing/gtest/include/gtest/gtest.h" #include <string.h> diff --git a/gpu/command_buffer/service/test_helper.h b/gpu/command_buffer/service/test_helper.h index 5793e44..16e3e0e 100644 --- a/gpu/command_buffer/service/test_helper.h +++ b/gpu/command_buffer/service/test_helper.h @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -6,7 +6,6 @@ #define GPU_COMMAND_BUFFER_SERVICE_TEST_HELPER_H_ #include "gpu/command_buffer/common/gl_mock.h" -#include "gpu/GLES2/gles2_command_buffer.h" namespace gpu { namespace gles2 { diff --git a/gpu/command_buffer/service/texture_manager.cc b/gpu/command_buffer/service/texture_manager.cc index c37f375..02f5ab9 100644 --- a/gpu/command_buffer/service/texture_manager.cc +++ b/gpu/command_buffer/service/texture_manager.cc @@ -7,7 +7,6 @@ #include "gpu/command_buffer/common/gles2_cmd_utils.h" #include "gpu/command_buffer/service/feature_info.h" #include "gpu/command_buffer/service/gles2_cmd_decoder.h" -#include "gpu/GLES2/gles2_command_buffer.h" namespace gpu { namespace gles2 { diff --git a/gpu/command_buffer/service/texture_manager_unittest.cc b/gpu/command_buffer/service/texture_manager_unittest.cc index dd634e8..6800481 100644 --- a/gpu/command_buffer/service/texture_manager_unittest.cc +++ b/gpu/command_buffer/service/texture_manager_unittest.cc @@ -5,7 +5,6 @@ #include "gpu/command_buffer/service/texture_manager.h" #include "base/memory/scoped_ptr.h" -#include "gpu/GLES2/gles2_command_buffer.h" #include "gpu/command_buffer/common/gl_mock.h" #include "gpu/command_buffer/service/feature_info.h" #include "gpu/command_buffer/service/test_helper.h" diff --git a/gpu/command_buffer/service/vertex_attrib_manager_unittest.cc b/gpu/command_buffer/service/vertex_attrib_manager_unittest.cc index 1d99ea7..49c1883 100644 --- a/gpu/command_buffer/service/vertex_attrib_manager_unittest.cc +++ b/gpu/command_buffer/service/vertex_attrib_manager_unittest.cc @@ -5,7 +5,6 @@ #include "gpu/command_buffer/service/vertex_attrib_manager.h" #include "base/memory/scoped_ptr.h" -#include "gpu/GLES2/gles2_command_buffer.h" #include "gpu/command_buffer/common/gl_mock.h" #include "gpu/command_buffer/service/feature_info.h" #include "gpu/command_buffer/service/test_helper.h" |