diff options
| author | apatrick@chromium.org <apatrick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-27 20:30:45 +0000 |
|---|---|---|
| committer | apatrick@chromium.org <apatrick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-27 20:30:45 +0000 |
| commit | 1b1bba77bb2fe952a651c07b11d617709ccd2fcf (patch) | |
| tree | 2941d33c7ea0f1fc40b10e823771a03f3dcd6287 /gpu/demos/framework/plugin.cc | |
| parent | 80ec6548d3f012c9b01e5dd5db39cb78c94c904b (diff) | |
| download | chromium_src-1b1bba77bb2fe952a651c07b11d617709ccd2fcf.zip chromium_src-1b1bba77bb2fe952a651c07b11d617709ccd2fcf.tar.gz chromium_src-1b1bba77bb2fe952a651c07b11d617709ccd2fcf.tar.bz2 | |
Windows now uses the TLS API instead of __declspec(thread) for client side command buffer code compiled into DLLs. Other platforms use the pthreads API. This is because the __declspec(thread) approach does not on some platforms, including Windows XP and Mac.
This is used for thread local pointers to the GL and PGL contexts. This unfortunate because the PGL and GL APIs do not generally explicitly reference a context. The current context is set with a call to pglMakeCurrent.
An unfortunate consequence is that now in Pepper plugins, every call to a GL function will call TlsGetValue to get the thread's current context, which could have performance issues.
I can't use base::ThreadLocalPointer because this code is compiled into an untrusted NaCl module and we don't want Chromium dependencies.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/553050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37300 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gpu/demos/framework/plugin.cc')
| -rw-r--r-- | gpu/demos/framework/plugin.cc | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/gpu/demos/framework/plugin.cc b/gpu/demos/framework/plugin.cc index b5278b1..dafcffe 100644 --- a/gpu/demos/framework/plugin.cc +++ b/gpu/demos/framework/plugin.cc @@ -92,7 +92,11 @@ Plugin::Plugin(NPP npp) } Plugin::~Plugin() { + // Destroy demo while GL context is current and before it is destroyed. + pglMakeCurrent(pgl_context_); + demo_.reset(); pglMakeCurrent(NULL); + pglDestroyContext(pgl_context_); } |